Re: [PATCH v5 06/34] function_graph: Allow multiple users to attach to function graph

2023-12-26 Thread Google
Hi, On Wed, 20 Dec 2023 00:45:40 +0900 Masami Hiramatsu (Google) wrote: > OK, I think we need a "rsrv_ret_stack" index. Basically new one will do; > > (1) increment rsrv_ret_stack > (2) write a reserve type entry > (3) set curr_ret_stack = rsrv_ret_stack > > And before those, > > (0) if

Re: [PATCH v5 06/34] function_graph: Allow multiple users to attach to function graph

2023-12-19 Thread Google
On Tue, 19 Dec 2023 14:23:37 +0100 Jiri Olsa wrote: > On Mon, Dec 18, 2023 at 10:12:45PM +0900, Masami Hiramatsu (Google) wrote: > > SNIP > > > /* Both enabled by default (can be cleared by function_graph tracer flags > > */ > > static bool fgraph_sleep_time = true; > > > > @@ -126,9

Re: [PATCH v5 06/34] function_graph: Allow multiple users to attach to function graph

2023-12-19 Thread Jiri Olsa
On Mon, Dec 18, 2023 at 10:12:45PM +0900, Masami Hiramatsu (Google) wrote: SNIP > /* Both enabled by default (can be cleared by function_graph tracer flags */ > static bool fgraph_sleep_time = true; > > @@ -126,9 +247,34 @@ ftrace_push_return_trace(unsigned long ret, unsigned > long func, >

[PATCH v5 06/34] function_graph: Allow multiple users to attach to function graph

2023-12-18 Thread Masami Hiramatsu (Google)
From: Steven Rostedt (VMware) Allow for multiple users to attach to function graph tracer at the same time. Only 16 simultaneous users can attach to the tracer. This is because there's an array that stores the pointers to the attached fgraph_ops. When a function being traced is entered, each of