Re: [PATCH v5 07/28] fpga: dfl: add chardev support for feature devices

On Thu, Jun 07, 2018 at 01:03:18PM -0500, Alan Tull wrote: > On Wed, Jun 6, 2018 at 7:24 AM, Wu Hao wrote: > > Hi Hao, > > One more... > > >> > +static dev_t dfl_get_devt(enum dfl_fpga_devt_type type, int id) > >> > +{ > >> > + WARN_ON(type >= DFL_FPGA_DEVT_MAX); > >> > + > >> > + r

Re: [PATCH v5 07/28] fpga: dfl: add chardev support for feature devices

On Wed, Jun 6, 2018 at 7:24 AM, Wu Hao wrote: Hi Hao, One more... >> > +static dev_t dfl_get_devt(enum dfl_fpga_devt_type type, int id) >> > +{ >> > + WARN_ON(type >= DFL_FPGA_DEVT_MAX); >> > + >> > + return MKDEV(MAJOR(dfl_chrdevs[type].devt), id); >> > +} >> > + >> > +/** >> > + *

Re: [PATCH v5 07/28] fpga: dfl: add chardev support for feature devices

On Tue, Jun 05, 2018 at 03:21:48PM -0500, Alan Tull wrote: > On Tue, May 1, 2018 at 9:50 PM, Wu Hao wrote: > > Hi Hao, > > > For feature devices drivers, both the FPGA Management Engine (FME) and > > Accelerated Function Unit (AFU) driver need to expose user interfaces via > > the device file, f

Re: [PATCH v5 07/28] fpga: dfl: add chardev support for feature devices

On Tue, May 1, 2018 at 9:50 PM, Wu Hao wrote: Hi Hao, > For feature devices drivers, both the FPGA Management Engine (FME) and > Accelerated Function Unit (AFU) driver need to expose user interfaces via > the device file, for example, mmap and ioctls. > > This patch adds chardev support in the d

[PATCH v5 07/28] fpga: dfl: add chardev support for feature devices

For feature devices drivers, both the FPGA Management Engine (FME) and Accelerated Function Unit (AFU) driver need to expose user interfaces via the device file, for example, mmap and ioctls. This patch adds chardev support in the dfl driver for feature devices, FME and AFU. It reserves the charde