Re: [PATCH v5 08/12] zsmalloc: introduce zspage structure

2016-05-16 Thread Sergey Senozhatsky
On (05/17/16 10:14), Minchan Kim wrote: [..] > > can we also switch create_cache() to errnos? I just like a bit > > better > > return -ENOMEM; > > else > > return 0; > > > > than > > > > return 1; > > else > > return 0; > > > > Hmm, of

Re: [PATCH v5 08/12] zsmalloc: introduce zspage structure

2016-05-16 Thread Sergey Senozhatsky
On (05/17/16 10:14), Minchan Kim wrote: [..] > > can we also switch create_cache() to errnos? I just like a bit > > better > > return -ENOMEM; > > else > > return 0; > > > > than > > > > return 1; > > else > > return 0; > > > > Hmm, of

Re: [PATCH v5 08/12] zsmalloc: introduce zspage structure

2016-05-16 Thread Minchan Kim
On Mon, May 16, 2016 at 12:09:41PM +0900, Sergey Senozhatsky wrote: > On (05/09/16 11:20), Minchan Kim wrote: > > We have squeezed meta data of zspage into first page's descriptor. > > So, to get meta data from subpage, we should get first page first > > of all. But it makes trouble to implment

Re: [PATCH v5 08/12] zsmalloc: introduce zspage structure

2016-05-16 Thread Minchan Kim
On Mon, May 16, 2016 at 12:09:41PM +0900, Sergey Senozhatsky wrote: > On (05/09/16 11:20), Minchan Kim wrote: > > We have squeezed meta data of zspage into first page's descriptor. > > So, to get meta data from subpage, we should get first page first > > of all. But it makes trouble to implment

Re: [PATCH v5 08/12] zsmalloc: introduce zspage structure

2016-05-15 Thread Sergey Senozhatsky
On (05/09/16 11:20), Minchan Kim wrote: > We have squeezed meta data of zspage into first page's descriptor. > So, to get meta data from subpage, we should get first page first > of all. But it makes trouble to implment page migration feature > of zsmalloc because any place where to get first page

Re: [PATCH v5 08/12] zsmalloc: introduce zspage structure

2016-05-15 Thread Sergey Senozhatsky
On (05/09/16 11:20), Minchan Kim wrote: > We have squeezed meta data of zspage into first page's descriptor. > So, to get meta data from subpage, we should get first page first > of all. But it makes trouble to implment page migration feature > of zsmalloc because any place where to get first page

[PATCH v5 08/12] zsmalloc: introduce zspage structure

2016-05-08 Thread Minchan Kim
We have squeezed meta data of zspage into first page's descriptor. So, to get meta data from subpage, we should get first page first of all. But it makes trouble to implment page migration feature of zsmalloc because any place where to get first page from subpage can be raced with first page

[PATCH v5 08/12] zsmalloc: introduce zspage structure

2016-05-08 Thread Minchan Kim
We have squeezed meta data of zspage into first page's descriptor. So, to get meta data from subpage, we should get first page first of all. But it makes trouble to implment page migration feature of zsmalloc because any place where to get first page from subpage can be raced with first page