Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-23 Thread Sukadev Bhattiprolu
Aaro Koskinen [aaro.koski...@iki.fi] wrote: | Hi, | | On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: | > powerpc/perf: Adjust callchain based on DWARF debug info | > | > When saving the callchain on Power, the kernel conservatively saves excess | > entries in the callchain.

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-23 Thread Jiri Olsa
On Tue, Sep 23, 2014 at 12:33:45AM +0300, Aaro Koskinen wrote: > Hi, > > On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: > > powerpc/perf: Adjust callchain based on DWARF debug info > > > > When saving the callchain on Power, the kernel conservatively saves excess > >

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-23 Thread Jiri Olsa
On Tue, Sep 23, 2014 at 12:33:45AM +0300, Aaro Koskinen wrote: Hi, On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: powerpc/perf: Adjust callchain based on DWARF debug info When saving the callchain on Power, the kernel conservatively saves excess entries in the

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-23 Thread Sukadev Bhattiprolu
Aaro Koskinen [aaro.koski...@iki.fi] wrote: | Hi, | | On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: | powerpc/perf: Adjust callchain based on DWARF debug info | | When saving the callchain on Power, the kernel conservatively saves excess | entries in the callchain. A

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-22 Thread Aaro Koskinen
Hi, On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: > powerpc/perf: Adjust callchain based on DWARF debug info > > When saving the callchain on Power, the kernel conservatively saves excess > entries in the callchain. A few of these entries are needed in some cases > but not

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-22 Thread Aaro Koskinen
Hi, On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: powerpc/perf: Adjust callchain based on DWARF debug info When saving the callchain on Power, the kernel conservatively saves excess entries in the callchain. A few of these entries are needed in some cases but not

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-25 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | | you could use __maybe_unused for the 'skip_idx' Yes, here is the updated patch. --- powerpc/perf: Adjust callchain based on DWARF debug info When saving the callchain on Power, the kernel conservatively saves excess entries in the callchain. A few of

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-25 Thread Jiri Olsa
On Tue, Jun 24, 2014 at 05:00:52PM -0700, Sukadev Bhattiprolu wrote: > [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info superflous ^^^ > > When saving the callchain on Power, the kernel conservatively saves excess > entries in the callchain. A few of t

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-25 Thread Jiri Olsa
On Tue, Jun 24, 2014 at 05:00:52PM -0700, Sukadev Bhattiprolu wrote: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info superflous ^^^ When saving the callchain on Power, the kernel conservatively saves excess entries in the callchain. A few of these entries are needed

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-25 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | | you could use __maybe_unused for the 'skip_idx' Yes, here is the updated patch. --- powerpc/perf: Adjust callchain based on DWARF debug info When saving the callchain on Power, the kernel conservatively saves excess entries in the callchain. A few of

[PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-24 Thread Sukadev Bhattiprolu
[PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info When saving the callchain on Power, the kernel conservatively saves excess entries in the callchain. A few of these entries are needed in some cases but not others. We should use the DWARF debug information to determine when

[PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-24 Thread Sukadev Bhattiprolu
[PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info When saving the callchain on Power, the kernel conservatively saves excess entries in the callchain. A few of these entries are needed in some cases but not others. We should use the DWARF debug information to determine when