Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-23 Thread Dmitry Torokhov
On Mon, Mar 23, 2015 at 10:57:05AM -0700, Jonathan Richardson wrote: > On 15-03-21 09:24 PM, Dmitry Torokhov wrote: > > Hi Jonathan, > > > > On Fri, Mar 20, 2015 at 05:57:25PM -0700, Jonathan Richardson wrote: > >> +config TOUCHSCREEN_IPROC > >> + tristate "IPROC touch panel driver support" > >

Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-23 Thread Jonathan Richardson
On 15-03-21 09:24 PM, Dmitry Torokhov wrote: > Hi Jonathan, > > On Fri, Mar 20, 2015 at 05:57:25PM -0700, Jonathan Richardson wrote: >> +config TOUCHSCREEN_IPROC >> +tristate "IPROC touch panel driver support" > > I think this should depend on ARCH_BCM_IPROC || COMPILE_TEST, right? > > (No n

Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-23 Thread Dmitry Torokhov
Hi Bo, On Mon, Mar 23, 2015 at 06:14:17PM +0800, Bo Shen wrote: > Hi Jonathan Richardson, > > On 03/21/2015 08:57 AM, Jonathan Richardson wrote: > >+static struct platform_driver iproc_ts_driver = { > >+.probe = iproc_ts_probe, > > Just a little curious, is the .remove function missing or it

Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-23 Thread Bo Shen
Hi Jonathan Richardson, On 03/21/2015 08:57 AM, Jonathan Richardson wrote: +static struct platform_driver iproc_ts_driver = { + .probe = iproc_ts_probe, Just a little curious, is the .remove function missing or it doesn't need it. Thanks. + .driver = { + .name

Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-21 Thread Dmitry Torokhov
Hi Jonathan, On Fri, Mar 20, 2015 at 05:57:25PM -0700, Jonathan Richardson wrote: > +config TOUCHSCREEN_IPROC > + tristate "IPROC touch panel driver support" I think this should depend on ARCH_BCM_IPROC || COMPILE_TEST, right? (No need to resubmit). Thanks. -- Dmitry -- To unsubscribe fro

[PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-20 Thread Jonathan Richardson
Add initial version of the Broadcom touchscreen driver. Reviewed-by: Ray Jui Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/input/touchscreen/Kconfig | 11 + drivers/input/touchscreen/Makefile|1 + drivers/input/touchsc