Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Michal Kubecek
On Mon, May 04, 2020 at 10:55:56AM +0200, Oleksij Rempel wrote: > On Mon, May 04, 2020 at 10:37:34AM +0200, Michal Kubecek wrote: > > On Mon, May 04, 2020 at 10:04:17AM +0200, Oleksij Rempel wrote: > > > @Michal, > > > > > > i noticed that linkmodes_fill_reply() some times get not enough > > > tai

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Michal Kubecek
On Mon, May 04, 2020 at 12:10:29PM +0200, Oleksij Rempel wrote: > > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > > > index ac2784192472f..42dda9d2082ee 100644 > > > --- a/drivers/net/phy/phy_device.c > > > +++ b/drivers/net/phy/phy_device.c > > > @@ -1768,6 +1768,90

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Oleksij Rempel
On Mon, May 04, 2020 at 11:10:44AM +0200, Michal Kubecek wrote: > On Mon, May 04, 2020 at 09:12:13AM +0200, Oleksij Rempel wrote: > > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > > auto-negotiation support, we needed to be able to configure the > > MASTER-SLAVE role of

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Michal Kubecek
On Mon, May 04, 2020 at 09:12:13AM +0200, Oleksij Rempel wrote: > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > auto-negotiation support, we needed to be able to configure the > MASTER-SLAVE role of the port manually or from an application in user > space. > > The same

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Oleksij Rempel
On Mon, May 04, 2020 at 10:37:34AM +0200, Michal Kubecek wrote: > On Mon, May 04, 2020 at 10:04:17AM +0200, Oleksij Rempel wrote: > > @Michal, > > > > i noticed that linkmodes_fill_reply() some times get not enough > > tailroom. > > if data->peer_empty == 0 > > linkmodes_reply_size() size: 476 > >

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Michal Kubecek
On Mon, May 04, 2020 at 10:04:17AM +0200, Oleksij Rempel wrote: > @Michal, > > i noticed that linkmodes_fill_reply() some times get not enough > tailroom. > if data->peer_empty == 0 > linkmodes_reply_size() size: 476 > linkmodes_fill_reply() skb tailroom: 724 > > > if data->peer_empty == 1 > lin

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Oleksij Rempel
@Michal, i noticed that linkmodes_fill_reply() some times get not enough tailroom. if data->peer_empty == 0 linkmodes_reply_size() size: 476 linkmodes_fill_reply() skb tailroom: 724 if data->peer_empty == 1 linkmodes_reply_size() size: 216 linkmodes_fill_rep

[PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Oleksij Rempel
This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of auto-negotiation support, we needed to be able to configure the MASTER-SLAVE role of the port manually or from an application in user space. The same UAPI can be used for 1000BASE-T or MultiGBASE-T devices to force MASTER or S