Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Jacek, On 30 August 2018 at 11:26, Baolin Wang wrote: > Hi Jacek, > > On 30 August 2018 at 03:15, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> On 08/29/2018 11:48 AM, Baolin Wang wrote: >>> Hi Jacek, >>> >>> On 29 August 2018 at 04:25, Jacek Anaszewski >>> wrote: On 08/25/2018 09:51

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Jacek, On 30 August 2018 at 03:15, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/29/2018 11:48 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 29 August 2018 at 04:25, Jacek Anaszewski >> wrote: >>> On 08/25/2018 09:51 AM, Baolin Wang wrote: On 25 August 2018 at 04:44, Jacek Anaszewski

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Baolin, On 08/29/2018 11:48 AM, Baolin Wang wrote: > Hi Jacek, > > On 29 August 2018 at 04:25, Jacek Anaszewski > wrote: >> On 08/25/2018 09:51 AM, Baolin Wang wrote: >>> On 25 August 2018 at 04:44, Jacek Anaszewski >>> wrote: On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri 2

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

On 08/28/2018 11:13 PM, Bjorn Andersson wrote: > On Tue 28 Aug 13:25 PDT 2018, Jacek Anaszewski wrote: > >> On 08/25/2018 09:51 AM, Baolin Wang wrote: >>> On 25 August 2018 at 04:44, Jacek Anaszewski >>> wrote: On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri 2018-08-24 21:49:50, Ja

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Jacek, On 29 August 2018 at 04:25, Jacek Anaszewski wrote: > On 08/25/2018 09:51 AM, Baolin Wang wrote: >> On 25 August 2018 at 04:44, Jacek Anaszewski >> wrote: >>> On 08/24/2018 10:12 PM, Pavel Machek wrote: On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, > >>>

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

On Tue 28 Aug 13:25 PDT 2018, Jacek Anaszewski wrote: > On 08/25/2018 09:51 AM, Baolin Wang wrote: > > On 25 August 2018 at 04:44, Jacek Anaszewski > > wrote: > >> On 08/24/2018 10:12 PM, Pavel Machek wrote: > >>> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, > >

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

On Sat 25 Aug 00:51 PDT 2018, Baolin Wang wrote: > On 25 August 2018 at 04:44, Jacek Anaszewski > wrote: > > On 08/24/2018 10:12 PM, Pavel Machek wrote: > >> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > >>> Hi Pavel, > >>> > >>> On 08/24/2018 12:11 PM, Pavel Machek wrote: [..] > >>> +

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

On 08/25/2018 09:51 AM, Baolin Wang wrote: > On 25 August 2018 at 04:44, Jacek Anaszewski > wrote: >> On 08/24/2018 10:12 PM, Pavel Machek wrote: >>> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: Hi Pavel, On 08/24/2018 12:11 PM, Pavel Machek wrote: > Hi! > >> I t

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

On 25 August 2018 at 04:44, Jacek Anaszewski wrote: > On 08/24/2018 10:12 PM, Pavel Machek wrote: >> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: >>> Hi Pavel, >>> >>> On 08/24/2018 12:11 PM, Pavel Machek wrote: Hi! > I think that it would be more flexible if software pattern

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: >> Hi Pavel, >> >> On 08/24/2018 12:11 PM, Pavel Machek wrote: >>> Hi! >>> I think that it would be more flexible if software pattern fallback was applied in case of pattern_set failure. Othe

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, > > On 08/24/2018 12:11 PM, Pavel Machek wrote: > > Hi! > > > >> I think that it would be more flexible if software pattern fallback > >> was applied in case of pattern_set failure. Otherwise, it would > >> lead to the situation wher

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Pavel, On 08/24/2018 12:11 PM, Pavel Machek wrote: > Hi! > >> I think that it would be more flexible if software pattern fallback >> was applied in case of pattern_set failure. Otherwise, it would >> lead to the situation where LED class devices that support hardware >> blinking couldn't be ap

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi! > I think that it would be more flexible if software pattern fallback > was applied in case of pattern_set failure. Otherwise, it would > lead to the situation where LED class devices that support hardware > blinking couldn't be applied the same set of patterns as LED class > devices that don'

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Jacek, On 11 August 2018 at 02:10, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/10/2018 05:26 PM, Baolin Wang wrote: >> Hi Jacek, >> >> On 9 August 2018 at 21:21, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> On 08/09/2018 07:48 AM, Baolin Wang wrote: >>> [...] +static int pat

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Baolin, On 08/10/2018 05:26 PM, Baolin Wang wrote: > Hi Jacek, > > On 9 August 2018 at 21:21, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> On 08/09/2018 07:48 AM, Baolin Wang wrote: >> [...] >>> +static int pattern_trig_start_pattern(struct pattern_trig_data *data, >>> +

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Jacek, On 9 August 2018 at 21:21, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/09/2018 07:48 AM, Baolin Wang wrote: > [...] >> +static int pattern_trig_start_pattern(struct pattern_trig_data *data, >> + struct led_classdev *led_cdev) >> +{ >>

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Baolin, On 08/09/2018 07:48 AM, Baolin Wang wrote: [...] > +static int pattern_trig_start_pattern(struct pattern_trig_data *data, > + struct led_classdev *led_cdev) > +{ > + if (!data->npatterns) > + return 0; > + > +

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Jacek, On 9 August 2018 at 05:28, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/08/2018 08:01 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 8 August 2018 at 05:54, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> Thank you for addressing the review remarks. >>> Since the patch set is target

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Baolin, On 08/08/2018 08:01 AM, Baolin Wang wrote: > Hi Jacek, > > On 8 August 2018 at 05:54, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> Thank you for addressing the review remarks. >> Since the patch set is targeted for 4.19, then we have three weeks >> before it will be merged to the fo

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Jacek, On 8 August 2018 at 05:54, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for addressing the review remarks. > Since the patch set is targeted for 4.19, then we have three weeks > before it will be merged to the for-next anyway. That said, I propose > one more modification, please t

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Hi Baolin, Thank you for addressing the review remarks. Since the patch set is targeted for 4.19, then we have three weeks before it will be merged to the for-next anyway. That said, I propose one more modification, please take a look below. On 08/06/2018 02:05 PM, Baolin Wang wrote: > Some LED c

[PATCH v5 1/2] leds: core: Introduce LED pattern trigger

Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This patch adds pattern trigger that LED device can configure the pattern and trigger it. Signed-off-by: Raphael Teysseyre Signed-off-by: Baolin Wang --- Cha