Re: [PATCH v5 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-11 Thread Waiman Long
On 4/11/25 1:11 PM, Michal Koutný wrote: Hello. On Mon, Apr 07, 2025 at 12:23:15PM -0400, Waiman Long wrote: --- a/mm/memcontrol-v1.h +++ b/mm/memcontrol-v1.h @@ -22,8 +22,6 @@ iter != NULL; \ iter = mem_cgroup_iter(NULL, iter, NULL))

Re: [PATCH v5 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-11 Thread Michal Koutný
Hello. On Mon, Apr 07, 2025 at 12:23:15PM -0400, Waiman Long wrote: > --- a/mm/memcontrol-v1.h > +++ b/mm/memcontrol-v1.h > @@ -22,8 +22,6 @@ >iter != NULL; \ >iter = mem_cgroup_iter(NULL, iter, NULL)) > > -unsigned long mem_cgroup_usage(str

[PATCH v5 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-09 Thread Waiman Long
The test_memcontrol selftest consistently fails its test_memcg_low sub-test due to the fact that two of its test child cgroups which have a memmory.low of 0 or an effective memory.low of 0 still have low events generated for them since mem_cgroup_below_low() use the ">=" operator when comparing to