Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

2017-12-19 Thread Paolo Bonzini
On 19/12/2017 03:40, Haozhong Zhang wrote: >> As discussed in the reply to v2, this should include WC too. The >> function name could become something like pat_pfn_downgraded_by_uc_mtrr. > > Or shall we just expose lookup_memtype(), and keep all other logic in > KVM? The function name still looks

Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

2017-12-18 Thread Haozhong Zhang
On 12/18/17 13:55 +0100, Paolo Bonzini wrote: > On 08/11/2017 08:56, Haozhong Zhang wrote: > > +bool pat_pfn_is_uc_or_uc_minus(unsigned long pfn) > > +{ > > + enum page_cache_mode cm = lookup_memtype(PFN_PHYS(pfn)); > > + > > + return cm == _PAGE_CACHE_MODE_UC || cm == _PAGE_CACHE_MODE_UC_MINUS

Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

2017-12-18 Thread Paolo Bonzini
On 08/11/2017 08:56, Haozhong Zhang wrote: > +bool pat_pfn_is_uc_or_uc_minus(unsigned long pfn) > +{ > + enum page_cache_mode cm = lookup_memtype(PFN_PHYS(pfn)); > + > + return cm == _PAGE_CACHE_MODE_UC || cm == _PAGE_CACHE_MODE_UC_MINUS; > +} > +EXPORT_SYMBOL_GPL(pat_pfn_is_uc_or_uc_minus)

Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

2017-11-15 Thread Haozhong Zhang
On 11/15/17 11:44 +0100, David Hildenbrand wrote: > On 08.11.2017 08:56, Haozhong Zhang wrote: > > It will be used by KVM to check whether a pfn should be > > mapped to guest as UC. > > > > Signed-off-by: Haozhong Zhang > > --- > > arch/x86/include/asm/pat.h | 2 ++ > > arch/x86/mm/pat.c

Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

2017-11-15 Thread Haozhong Zhang
On 11/15/17 07:17 -0800, Dan Williams wrote: > On Tue, Nov 7, 2017 at 11:56 PM, Haozhong Zhang > wrote: > > It will be used by KVM to check whether a pfn should be > > mapped to guest as UC. > > > > Signed-off-by: Haozhong Zhang > > --- > > arch/x86/include/asm/pat.h | 2 ++ > > arch/x86/mm/pat

Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

2017-11-15 Thread Dan Williams
On Tue, Nov 7, 2017 at 11:56 PM, Haozhong Zhang wrote: > It will be used by KVM to check whether a pfn should be > mapped to guest as UC. > > Signed-off-by: Haozhong Zhang > --- > arch/x86/include/asm/pat.h | 2 ++ > arch/x86/mm/pat.c | 16 > 2 files changed, 18 insert

Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

2017-11-15 Thread David Hildenbrand
On 08.11.2017 08:56, Haozhong Zhang wrote: > It will be used by KVM to check whether a pfn should be > mapped to guest as UC. > > Signed-off-by: Haozhong Zhang > --- > arch/x86/include/asm/pat.h | 2 ++ > arch/x86/mm/pat.c | 16 > 2 files changed, 18 insertions(+) > >

[PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

2017-11-07 Thread Haozhong Zhang
It will be used by KVM to check whether a pfn should be mapped to guest as UC. Signed-off-by: Haozhong Zhang --- arch/x86/include/asm/pat.h | 2 ++ arch/x86/mm/pat.c | 16 2 files changed, 18 insertions(+) diff --git a/arch/x86/include/asm/pat.h b/arch/x86/include/asm