Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-14 Thread Marc Zyngier
On 14/10/15 10:17, Thomas Gleixner wrote: > Marc, > > On Wed, 14 Oct 2015, Marc Zyngier wrote: >> To me, it feels like we're spreading the complexity across multiple >> layers instead of keeping it localized. It also means that next time >> some crazy HW dude comes up with a similar idea (and I ha

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-14 Thread Thomas Gleixner
Marc, On Wed, 14 Oct 2015, Marc Zyngier wrote: > To me, it feels like we're spreading the complexity across multiple > layers instead of keeping it localized. It also means that next time > some crazy HW dude comes up with a similar idea (and I have little doubt > this will happen sooner than late

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-14 Thread majun (F)
在 2015/10/14 16:20, Thomas Gleixner 写道: > On Wed, 14 Oct 2015, majun (F) wrote: >> But there is no interrupt-map property in GIC or mbigen node. > > Again: I'm not a DT expert. Please discuss that with Marc and the DT > wizards. > > Thanks, > > tglx > > . Ok. Marc, what's your suggesti

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-14 Thread Marc Zyngier
Hi Thomas, Sorry it took me so long to come back to you on that one, I really needed to wrap my head around it. On 11/10/15 17:45, Thomas Gleixner wrote: > On Sun, 11 Oct 2015, Marc Zyngier wrote: >> On Sun, 11 Oct 2015 11:54:49 +0200 >> Thomas Gleixner wrote: >> >>> On Sat, 10 Oct 2015, Marc Zy

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-14 Thread majun (F)
Hi Thomas: 在 2015/10/13 14:55, Thomas Gleixner 写道: > Majun, > > On Tue, 13 Oct 2015, majun (F) wrote: >> 在 2015/10/12 0:45, Thomas Gleixner 写道: >>> So now in the mbigen case this looks like this: >>> >>> [MSI-BUS] - [MBIGEN]<---[Device interrupt] >>> >>> Again, you have a

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-14 Thread Thomas Gleixner
On Wed, 14 Oct 2015, majun (F) wrote: > But there is no interrupt-map property in GIC or mbigen node. Again: I'm not a DT expert. Please discuss that with Marc and the DT wizards. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-12 Thread Thomas Gleixner
Majun, On Tue, 13 Oct 2015, majun (F) wrote: > 在 2015/10/12 0:45, Thomas Gleixner 写道: > > So now in the mbigen case this looks like this: > > > > [MSI-BUS] - [MBIGEN]<---[Device interrupt] > > > > Again, you have a 'wire' from the device to the MSI unit (MBIGEN) and > > w

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-12 Thread majun (F)
Hi Thomas: 在 2015/10/12 0:45, Thomas Gleixner 写道: > On Sun, 11 Oct 2015, Marc Zyngier wrote: >> On Sun, 11 Oct 2015 11:54:49 +0200 >> Thomas Gleixner wrote: >> >>> On Sat, 10 Oct 2015, Marc Zyngier wrote: On Sat, 10 Oct 2015 17:01:32 +0800 "majun (F)" wrote: > But there is a proble

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-11 Thread Thomas Gleixner
On Sun, 11 Oct 2015, Marc Zyngier wrote: > On Sun, 11 Oct 2015 11:54:49 +0200 > Thomas Gleixner wrote: > > > On Sat, 10 Oct 2015, Marc Zyngier wrote: > > > On Sat, 10 Oct 2015 17:01:32 +0800 > > > "majun (F)" wrote: > > > > But there is a problem If i make the structure like you said. > > > > >

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-11 Thread Marc Zyngier
On Sun, 11 Oct 2015 11:54:49 +0200 Thomas Gleixner wrote: > On Sat, 10 Oct 2015, Marc Zyngier wrote: > > On Sat, 10 Oct 2015 17:01:32 +0800 > > "majun (F)" wrote: > > > But there is a problem If i make the structure like you said. > > > > > > For example, my hardware structure likes below: > >

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-11 Thread Thomas Gleixner
On Sat, 10 Oct 2015, Marc Zyngier wrote: > On Sat, 10 Oct 2015 17:01:32 +0800 > "majun (F)" wrote: > > But there is a problem If i make the structure like you said. > > > > For example, my hardware structure likes below: > > > > uart --> mbigen --> ITS-pMSI --> ITS --> GIC > > virq1 > >

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-10 Thread Marc Zyngier
On Sat, 10 Oct 2015 17:01:32 +0800 "majun (F)" wrote: > > > 在 2015/10/9 21:47, Thomas Gleixner 写道: > > On Sun, 4 Oct 2015, majun (F) wrote: > +info->reg_offset = get_mbigen_vec_reg_addr(info->nid, > info->local_pin_offset); > >>> > >>> So you fill in a structure with 5 fields

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-10 Thread majun (F)
在 2015/10/9 21:47, Thomas Gleixner 写道: > On Sun, 4 Oct 2015, majun (F) wrote: + info->reg_offset = get_mbigen_vec_reg_addr(info->nid, info->local_pin_offset); >>> >>> So you fill in a structure with 5 fields and the only information [...] >> On the other hand, it's a interrupt control

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-09 Thread Thomas Gleixner
On Sun, 4 Oct 2015, majun (F) wrote: > >> + info->reg_offset = get_mbigen_vec_reg_addr(info->nid, > >> info->local_pin_offset); > > > > So you fill in a structure with 5 fields and the only information > > which is ever used is local_pin_offset. > > > > What's the point of this exercise? > >

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-10-04 Thread majun (F)
Hi Thomas: 在 2015/10/1 5:37, Thomas Gleixner 写道: > On Wed, 30 Sep 2015, MaJun wrote: > > First of all. > > [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller > > is not a proper subject line, but that's the least of your problems. >

Re: [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-09-30 Thread Thomas Gleixner
On Wed, 30 Sep 2015, MaJun wrote: First of all. [PATCH v5 1/3] initialize each mbigen device node as a interrupt controller is not a proper subject line, but that's the least of your problems. > +#include > +#include > +#include > +#include > +#include >

[PATCH v5 1/3] initialize each mbigen device node as a interrupt controller.

2015-09-30 Thread MaJun
From: Ma Jun Mbigen means Message Based Interrupt Generator(MBIGEN). Its a kind of interrupt controller that collects the interrupts from external devices and generate msi interrupt. Mbigen is applied to reduce the number of wire connected interrupts. As the peripherals increasing, the interr