Re: v4.17 regression: PowerMac G3 won't boot, was Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Fri, 2018-08-31 at 14:35 +1000, Benjamin Herrenschmidt wrote: > > > If I force output with "-f", the resulting file has no occurrences > > of "phandle". > > Are you booting with BootX or Open Firmware ? Assuming you are using BootX (or miBoot), can you try this patch ? ---

Re: v4.17 regression: PowerMac G3 won't boot, was Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Fri, 2018-08-31 at 14:35 +1000, Benjamin Herrenschmidt wrote: > > > If I force output with "-f", the resulting file has no occurrences > > of "phandle". > > Are you booting with BootX or Open Firmware ? Assuming you are using BootX (or miBoot), can you try this patch ? ---

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Wed, Jun 13, 2018 at 4:47 PM, Frank Rowand wrote: > On 06/13/18 07:42, Alan Tull wrote: >> On Tue, Jun 12, 2018 at 1:16 PM, Alan Tull wrote: >>> On Sun, Mar 4, 2018 at 6:14 PM, wrote: >>> >>> Hi Frank, >>> >>> I'm investigating a refcount use-after-free warning that happens after >>>

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Wed, Jun 13, 2018 at 4:47 PM, Frank Rowand wrote: > On 06/13/18 07:42, Alan Tull wrote: >> On Tue, Jun 12, 2018 at 1:16 PM, Alan Tull wrote: >>> On Sun, Mar 4, 2018 at 6:14 PM, wrote: >>> >>> Hi Frank, >>> >>> I'm investigating a refcount use-after-free warning that happens after >>>

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On 06/13/18 07:42, Alan Tull wrote: > On Tue, Jun 12, 2018 at 1:16 PM, Alan Tull wrote: >> On Sun, Mar 4, 2018 at 6:14 PM, wrote: >> >> Hi Frank, >> >> I'm investigating a refcount use-after-free warning that happens after >> overlays are applied, removed, reapplied a few (typically three)

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On 06/13/18 07:42, Alan Tull wrote: > On Tue, Jun 12, 2018 at 1:16 PM, Alan Tull wrote: >> On Sun, Mar 4, 2018 at 6:14 PM, wrote: >> >> Hi Frank, >> >> I'm investigating a refcount use-after-free warning that happens after >> overlays are applied, removed, reapplied a few (typically three)

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Tue, Jun 12, 2018 at 1:16 PM, Alan Tull wrote: > On Sun, Mar 4, 2018 at 6:14 PM, wrote: > > Hi Frank, > > I'm investigating a refcount use-after-free warning that happens after > overlays are applied, removed, reapplied a few (typically three) times > (see below). This is new in v4.17,

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Tue, Jun 12, 2018 at 1:16 PM, Alan Tull wrote: > On Sun, Mar 4, 2018 at 6:14 PM, wrote: > > Hi Frank, > > I'm investigating a refcount use-after-free warning that happens after > overlays are applied, removed, reapplied a few (typically three) times > (see below). This is new in v4.17,

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Sun, Mar 4, 2018 at 6:14 PM, wrote: Hi Frank, I'm investigating a refcount use-after-free warning that happens after overlays are applied, removed, reapplied a few (typically three) times (see below). This is new in v4.17, didn't happen in v4.16. As I was investigating I found that

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Sun, Mar 4, 2018 at 6:14 PM, wrote: Hi Frank, I'm investigating a refcount use-after-free warning that happens after overlays are applied, removed, reapplied a few (typically three) times (see below). This is new in v4.17, didn't happen in v4.16. As I was investigating I found that

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On 03/09/18 15:03, Rob Herring wrote: > On Sun, Mar 04, 2018 at 04:14:47PM -0800, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> Create a cache of the nodes that contain a phandle property. Use this >> cache to find the node for a given phandle value instead of

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On 03/09/18 15:03, Rob Herring wrote: > On Sun, Mar 04, 2018 at 04:14:47PM -0800, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> Create a cache of the nodes that contain a phandle property. Use this >> cache to find the node for a given phandle value instead of scanning >> the

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Sun, Mar 04, 2018 at 04:14:47PM -0800, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Create a cache of the nodes that contain a phandle property. Use this > cache to find the node for a given phandle value instead of scanning > the devicetree to find the node.

Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

On Sun, Mar 04, 2018 at 04:14:47PM -0800, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Create a cache of the nodes that contain a phandle property. Use this > cache to find the node for a given phandle value instead of scanning > the devicetree to find the node. If the phandle value

[PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

From: Frank Rowand Create a cache of the nodes that contain a phandle property. Use this cache to find the node for a given phandle value instead of scanning the devicetree to find the node. If the phandle value is not found in the cache, of_find_node_by_phandle() will

[PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

From: Frank Rowand Create a cache of the nodes that contain a phandle property. Use this cache to find the node for a given phandle value instead of scanning the devicetree to find the node. If the phandle value is not found in the cache, of_find_node_by_phandle() will fall back to the tree