On 2014/10/22 15:58, Ulf Hansson wrote:
[...]
+
+ list_for_each_entry(de, &pd->dev_list, node) {
+ i += 1;
+ pm_clk_resume(pd->dev);
Do you really need to call pm_clk_resume() number of times that there
are devices in power domain? Did you want it to be
On 22 October 2014 19:45, Dmitry Torokhov wrote:
> On Wed, Oct 22, 2014 at 09:58:34AM +0200, Ulf Hansson wrote:
>>
>> Using the devm_*API is supposed to work from here. I have kept this in
>> mind, while we added the new dev_pm_domain_attach|detach() API. The
>> buses also handles -EPROBE_DEFER.
>
On Wed, Oct 22, 2014 at 09:58:34AM +0200, Ulf Hansson wrote:
>
> Using the devm_*API is supposed to work from here. I have kept this in
> mind, while we added the new dev_pm_domain_attach|detach() API. The
> buses also handles -EPROBE_DEFER.
How do you ensure this? You have no control over from w
On 22 October 2014 10:07, Geert Uytterhoeven wrote:
> On Wed, Oct 22, 2014 at 9:58 AM, Ulf Hansson wrote:
>> Now, I just realized that while Geert added attach|detach_dev()
>> callbacks for the generic PM domain, those are both "void" callbacks.
>> It means the deferred probe error handling is br
On Wed, Oct 22, 2014 at 9:58 AM, Ulf Hansson wrote:
> Now, I just realized that while Geert added attach|detach_dev()
> callbacks for the generic PM domain, those are both "void" callbacks.
> It means the deferred probe error handling is broken for these
> callbacks. We should convert the attach_d
[...]
>>>
>>> +
>>> + list_for_each_entry(de, &pd->dev_list, node) {
>>> + i += 1;
>>> + pm_clk_resume(pd->dev);
>>
>> Do you really need to call pm_clk_resume() number of times that there
>> are devices in power domain? Did you want it to be
>>
>>
On 2014/10/22 3:58, Dmitry Torokhov wrote:
Hi Jinkun,
On Tue, Oct 21, 2014 at 02:13:26AM -0700, jinkun.hong wrote:
From: "jinkun.hong"
Add power domain drivers based on generic power domain for Rockchip platform,
and support RK3288.
Signed-off-by: Jack Dai
Signed-off-by: jinkun.hong
---
Hi Jinkun,
On Tue, Oct 21, 2014 at 02:13:26AM -0700, jinkun.hong wrote:
> From: "jinkun.hong"
>
> Add power domain drivers based on generic power domain for Rockchip platform,
> and support RK3288.
>
> Signed-off-by: Jack Dai
> Signed-off-by: jinkun.hong
>
> ---
>
> Changes in v5:
> - delet
From: "jinkun.hong"
Add power domain drivers based on generic power domain for Rockchip platform,
and support RK3288.
Signed-off-by: Jack Dai
Signed-off-by: jinkun.hong
---
Changes in v5:
- delete idle_lock
- add timeout in rockchip_pmu_set_idle_request()
Changes in v4:
- use list storage d
9 matches
Mail list logo
