Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-08-17 Thread Jarkko Sakkinen
On Tue, Jul 28, 2020 at 04:34:00PM +0900, Masami Hiramatsu wrote: > On Sat, 25 Jul 2020 12:21:10 +0200 > Ingo Molnar wrote: > > > > > * Jarkko Sakkinen wrote: > > > > > On Fri, Jul 24, 2020 at 11:17:11AM +0200, Ingo Molnar wrote: > > > > > > > > * Jarkko Sakkinen wrote: > > > > > > > > > --

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-28 Thread Masami Hiramatsu
On Sat, 25 Jul 2020 12:21:10 +0200 Ingo Molnar wrote: > > * Jarkko Sakkinen wrote: > > > On Fri, Jul 24, 2020 at 11:17:11AM +0200, Ingo Molnar wrote: > > > > > > * Jarkko Sakkinen wrote: > > > > > > > --- a/kernel/kprobes.c > > > > +++ b/kernel/kprobes.c > > > > @@ -564,7 +564,7 @@ static v

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-25 Thread Ingo Molnar
* Jarkko Sakkinen wrote: > On Fri, Jul 24, 2020 at 11:17:11AM +0200, Ingo Molnar wrote: > > > > * Jarkko Sakkinen wrote: > > > > > --- a/kernel/kprobes.c > > > +++ b/kernel/kprobes.c > > > @@ -564,7 +564,7 @@ static void kprobe_optimizer(struct work_struct *work) > > > cpus_read_lock(); >

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-24 Thread Jarkko Sakkinen
On Fri, Jul 24, 2020 at 11:17:11AM +0200, Ingo Molnar wrote: > > * Jarkko Sakkinen wrote: > > > --- a/kernel/kprobes.c > > +++ b/kernel/kprobes.c > > @@ -564,7 +564,7 @@ static void kprobe_optimizer(struct work_struct *work) > > cpus_read_lock(); > > mutex_lock(&text_mutex); > > /* L

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-24 Thread Jarkko Sakkinen
On Fri, Jul 24, 2020 at 11:46:31PM +0900, Masami Hiramatsu wrote: > On Fri, 24 Jul 2020 08:05:48 +0300 > Jarkko Sakkinen wrote: > > > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > > in order to remove the compile time dependency to it. > > This subject is a bit co

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-24 Thread Jarkko Sakkinen
On Fri, Jul 24, 2020 at 01:22:58PM +0300, Mike Rapoport wrote: > On Fri, Jul 24, 2020 at 08:05:48AM +0300, Jarkko Sakkinen wrote: > > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > > in order to remove the compile time dependency to it. > > > > Cc: linux...@kvack.org

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-24 Thread Jarkko Sakkinen
On Fri, Jul 24, 2020 at 11:13:19AM +0200, Ingo Molnar wrote: > > * Jarkko Sakkinen wrote: > > > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > > in order to remove the compile time dependency to it. > > > > Cc: linux...@kvack.org > > Cc: Andi Kleen > > Cc: Peter

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-24 Thread Masami Hiramatsu
On Fri, 24 Jul 2020 08:05:48 +0300 Jarkko Sakkinen wrote: > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > in order to remove the compile time dependency to it. This subject is a bit confusing. This is just wrapping modules_mutex in kpprobes. We still have compile

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-24 Thread Mike Rapoport
On Fri, Jul 24, 2020 at 08:05:48AM +0300, Jarkko Sakkinen wrote: > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > in order to remove the compile time dependency to it. > > Cc: linux...@kvack.org > Cc: Andi Kleen > Cc: Peter Zijlstra > Suggested-by: Masami Hiramatsu

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-24 Thread Ingo Molnar
* Jarkko Sakkinen wrote: > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -564,7 +564,7 @@ static void kprobe_optimizer(struct work_struct *work) > cpus_read_lock(); > mutex_lock(&text_mutex); > /* Lock modules while optimizing kprobes */ > - mutex_lock(&module_mutex

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-24 Thread Ingo Molnar
* Jarkko Sakkinen wrote: > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > in order to remove the compile time dependency to it. > > Cc: linux...@kvack.org > Cc: Andi Kleen > Cc: Peter Zijlstra > Suggested-by: Masami Hiramatsu > Signed-off-by: Jarkko Sakkinen

[PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-23 Thread Jarkko Sakkinen
Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex in order to remove the compile time dependency to it. Cc: linux...@kvack.org Cc: Andi Kleen Cc: Peter Zijlstra Suggested-by: Masami Hiramatsu Signed-off-by: Jarkko Sakkinen --- include/linux/module.h | 18 +++

[PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-23 Thread Jarkko Sakkinen
Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex in order to remove the compile time dependency to it. Cc: linux...@kvack.org Cc: Andi Kleen Cc: Peter Zijlstra Suggested-by: Masami Hiramatsu Signed-off-by: Jarkko Sakkinen --- include/linux/module.h | 18 +++