Re: [PATCH v5 1/6] perf tools: Derive trigger class from auxtrace_snapshot

2016-04-20 Thread Namhyung Kim
Hello, On Mon, Apr 18, 2016 at 02:55:27PM +, Wang Nan wrote: > Use 'trigger' to model operations which need to be executed when > an event (a signal, for example) is observed. > > States and transits: > > OFF--(on)--> READY --(toggle)--> TOGGLED > ^| >

Re: [PATCH v5 1/6] perf tools: Derive trigger class from auxtrace_snapshot

2016-04-20 Thread Namhyung Kim
Hello, On Mon, Apr 18, 2016 at 02:55:27PM +, Wang Nan wrote: > Use 'trigger' to model operations which need to be executed when > an event (a signal, for example) is observed. > > States and transits: > > OFF--(on)--> READY --(toggle)--> TOGGLED > ^| >

Re: [PATCH v5 1/6] perf tools: Derive trigger class from auxtrace_snapshot

2016-04-20 Thread Jiri Olsa
On Mon, Apr 18, 2016 at 02:55:27PM +, Wang Nan wrote: SNIP > -static volatile int auxtrace_snapshot_err; > static volatile int auxtrace_record__snapshot_started; > +static DEFINE_TRIGGER(auxtrace_snapshot); > > static void sig_handler(int sig) > { > @@ -282,11 +247,12 @@ static void

Re: [PATCH v5 1/6] perf tools: Derive trigger class from auxtrace_snapshot

2016-04-20 Thread Jiri Olsa
On Mon, Apr 18, 2016 at 02:55:27PM +, Wang Nan wrote: SNIP > -static volatile int auxtrace_snapshot_err; > static volatile int auxtrace_record__snapshot_started; > +static DEFINE_TRIGGER(auxtrace_snapshot); > > static void sig_handler(int sig) > { > @@ -282,11 +247,12 @@ static void

[PATCH v5 1/6] perf tools: Derive trigger class from auxtrace_snapshot

2016-04-18 Thread Wang Nan
Use 'trigger' to model operations which need to be executed when an event (a signal, for example) is observed. States and transits: OFF--(on)--> READY --(toggle)--> TOGGLED ^| | (ready) ||

[PATCH v5 1/6] perf tools: Derive trigger class from auxtrace_snapshot

2016-04-18 Thread Wang Nan
Use 'trigger' to model operations which need to be executed when an event (a signal, for example) is observed. States and transits: OFF--(on)--> READY --(toggle)--> TOGGLED ^| | (ready) ||