Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-16 Thread Vincent Guittot
On 15 September 2014 12:45, Morten Rasmussen wrote: > On Thu, Sep 11, 2014 at 03:04:44PM +0100, Peter Zijlstra wrote: >> On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: >> > > Also I'm not entirely sure I like the usage, utilization names/metrics. >> > > I would suggest to

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-16 Thread Vincent Guittot
On 15 September 2014 12:45, Morten Rasmussen morten.rasmus...@arm.com wrote: On Thu, Sep 11, 2014 at 03:04:44PM +0100, Peter Zijlstra wrote: On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: Also I'm not entirely sure I like the usage, utilization names/metrics. I would

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-15 Thread Morten Rasmussen
On Thu, Sep 11, 2014 at 03:04:44PM +0100, Peter Zijlstra wrote: > On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: > > > Also I'm not entirely sure I like the usage, utilization names/metrics. > > > I would suggest to reverse them. Call the pure running number > > > 'utilization'

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-15 Thread Morten Rasmussen
On Thu, Sep 11, 2014 at 01:34:12PM +0100, Peter Zijlstra wrote: > > @@ -4514,6 +4519,17 @@ static int select_idle_sibling(struct task_struct > > *p, int target) > > return target; > > } > > > > +static int get_cpu_utilization(int cpu) > > +{ > > + unsigned long usage =

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-15 Thread Morten Rasmussen
On Thu, Sep 11, 2014 at 01:34:12PM +0100, Peter Zijlstra wrote: @@ -4514,6 +4519,17 @@ static int select_idle_sibling(struct task_struct *p, int target) return target; } +static int get_cpu_utilization(int cpu) +{ + unsigned long usage = cpu_rq(cpu)-cfs.usage_load_avg;

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-15 Thread Morten Rasmussen
On Thu, Sep 11, 2014 at 03:04:44PM +0100, Peter Zijlstra wrote: On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: Also I'm not entirely sure I like the usage, utilization names/metrics. I would suggest to reverse them. Call the pure running number 'utilization' and this

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-12 Thread Vincent Guittot
On 11 September 2014 21:17, Nicolas Pitre wrote: >> >> Any other opinions before Vince goes and applies sed on patches? ;-) > > I don't mind either way, but for sure someone (possibly me) is going to > confuse the two soon enough. > > Please include in the code some formal definition in the

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-12 Thread Vincent Guittot
On 11 September 2014 21:17, Nicolas Pitre nicolas.pi...@linaro.org wrote: Any other opinions before Vince goes and applies sed on patches? ;-) I don't mind either way, but for sure someone (possibly me) is going to confuse the two soon enough. Please include in the code some formal

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-11 Thread Nicolas Pitre
On Thu, 11 Sep 2014, Peter Zijlstra wrote: > On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: > > > Also I'm not entirely sure I like the usage, utilization names/metrics. > > > I would suggest to reverse them. Call the pure running number > > > 'utilization' and this scaled with

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-11 Thread Peter Zijlstra
On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: > > Also I'm not entirely sure I like the usage, utilization names/metrics. > > I would suggest to reverse them. Call the pure running number > > 'utilization' and this scaled with capacity 'usage' or so. > > ok. i can invert

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-11 Thread Vincent Guittot
On 11 September 2014 14:34, Peter Zijlstra wrote: > On Tue, Aug 26, 2014 at 01:06:53PM +0200, Vincent Guittot wrote: >> Monitor the utilization level of each group of each sched_domain level. The >> utilization is the amount of cpu_capacity that is currently used on a CPU or >> group of CPUs. We

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-11 Thread Peter Zijlstra
On Tue, Aug 26, 2014 at 01:06:53PM +0200, Vincent Guittot wrote: > Monitor the utilization level of each group of each sched_domain level. The > utilization is the amount of cpu_capacity that is currently used on a CPU or > group of CPUs. We use the usage_load_avg to evaluate this utilization

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-11 Thread Peter Zijlstra
On Tue, Aug 26, 2014 at 01:06:53PM +0200, Vincent Guittot wrote: Monitor the utilization level of each group of each sched_domain level. The utilization is the amount of cpu_capacity that is currently used on a CPU or group of CPUs. We use the usage_load_avg to evaluate this utilization level.

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-11 Thread Vincent Guittot
On 11 September 2014 14:34, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 26, 2014 at 01:06:53PM +0200, Vincent Guittot wrote: Monitor the utilization level of each group of each sched_domain level. The utilization is the amount of cpu_capacity that is currently used on a CPU or group

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-11 Thread Peter Zijlstra
On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: Also I'm not entirely sure I like the usage, utilization names/metrics. I would suggest to reverse them. Call the pure running number 'utilization' and this scaled with capacity 'usage' or so. ok. i can invert 'usage' and

Re: [PATCH v5 10/12] sched: get CPU's utilization statistic

2014-09-11 Thread Nicolas Pitre
On Thu, 11 Sep 2014, Peter Zijlstra wrote: On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: Also I'm not entirely sure I like the usage, utilization names/metrics. I would suggest to reverse them. Call the pure running number 'utilization' and this scaled with capacity

[PATCH v5 10/12] sched: get CPU's utilization statistic

2014-08-26 Thread Vincent Guittot
Monitor the utilization level of each group of each sched_domain level. The utilization is the amount of cpu_capacity that is currently used on a CPU or group of CPUs. We use the usage_load_avg to evaluate this utilization level. In the special use case where the CPU is fully loaded by more than 1

[PATCH v5 10/12] sched: get CPU's utilization statistic

2014-08-26 Thread Vincent Guittot
Monitor the utilization level of each group of each sched_domain level. The utilization is the amount of cpu_capacity that is currently used on a CPU or group of CPUs. We use the usage_load_avg to evaluate this utilization level. In the special use case where the CPU is fully loaded by more than 1