Re: [PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-09 Thread Kent Overstreet
On Wed, Aug 08, 2012 at 11:52:51PM -0700, Tejun Heo wrote: > On Wed, Aug 08, 2012 at 07:56:10PM -0700, Kent Overstreet wrote: > > > So, bio_clone() loses its function comment. Also, does it even make > > > sense to call bio_clone() from fs_bio_set? > > > > I'll re add the function comment if you

Re: [PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-09 Thread Tejun Heo
On Wed, Aug 08, 2012 at 07:56:10PM -0700, Kent Overstreet wrote: > > So, bio_clone() loses its function comment. Also, does it even make > > sense to call bio_clone() from fs_bio_set? > > I'll re add the function comment if you want, just for a single line > wrapper I don't know if it's worth

Re: [PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-09 Thread Tejun Heo
On Wed, Aug 08, 2012 at 07:56:10PM -0700, Kent Overstreet wrote: So, bio_clone() loses its function comment. Also, does it even make sense to call bio_clone() from fs_bio_set? I'll re add the function comment if you want, just for a single line wrapper I don't know if it's worth the cost

Re: [PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-09 Thread Kent Overstreet
On Wed, Aug 08, 2012 at 11:52:51PM -0700, Tejun Heo wrote: On Wed, Aug 08, 2012 at 07:56:10PM -0700, Kent Overstreet wrote: So, bio_clone() loses its function comment. Also, does it even make sense to call bio_clone() from fs_bio_set? I'll re add the function comment if you want, just

Re: [PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-08 Thread Kent Overstreet
On Wed, Aug 08, 2012 at 04:21:20PM -0700, Tejun Heo wrote: > On Mon, Aug 06, 2012 at 03:08:40PM -0700, Kent Overstreet wrote: > > This consolidates some code, and will help in a later patch changing how > > bio cloning works. > > I think it would be better to introduce bio_clone*() functions in a

Re: [PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-08 Thread Tejun Heo
On Mon, Aug 06, 2012 at 03:08:40PM -0700, Kent Overstreet wrote: > This consolidates some code, and will help in a later patch changing how > bio cloning works. I think it would be better to introduce bio_clone*() functions in a separate patch and convert the users in a different one. > /** > -

Re: [PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-08 Thread Tejun Heo
On Mon, Aug 06, 2012 at 03:08:40PM -0700, Kent Overstreet wrote: This consolidates some code, and will help in a later patch changing how bio cloning works. I think it would be better to introduce bio_clone*() functions in a separate patch and convert the users in a different one. /** - *

Re: [PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-08 Thread Kent Overstreet
On Wed, Aug 08, 2012 at 04:21:20PM -0700, Tejun Heo wrote: On Mon, Aug 06, 2012 at 03:08:40PM -0700, Kent Overstreet wrote: This consolidates some code, and will help in a later patch changing how bio cloning works. I think it would be better to introduce bio_clone*() functions in a

[PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-06 Thread Kent Overstreet
This consolidates some code, and will help in a later patch changing how bio cloning works. Signed-off-by: Kent Overstreet --- block/blk-core.c|8 +--- drivers/md/dm.c |4 ++-- drivers/md/md.c | 20 +--- fs/bio.c| 16

[PATCH v5 11/12] block: Add bio_clone_bioset()

2012-08-06 Thread Kent Overstreet
This consolidates some code, and will help in a later patch changing how bio cloning works. Signed-off-by: Kent Overstreet koverstr...@google.com --- block/blk-core.c|8 +--- drivers/md/dm.c |4 ++-- drivers/md/md.c | 20 +--- fs/bio.c| 16