Re: [PATCH v5 11/14] software node: move small properties inline when copying

2019-10-17 Thread Dmitry Torokhov
On Fri, Oct 11, 2019 at 04:07:18PM -0700, Dmitry Torokhov wrote: > When copying/duplicating set of properties, move smaller properties that > were stored separately directly inside property entry structures. We can > move: > > - up to 8 bytes from U8 arrays > - up to 4 words > - up to 2 double wor

Re: [PATCH v5 11/14] software node: move small properties inline when copying

2019-10-16 Thread Dmitry Torokhov
On Wed, Oct 16, 2019 at 07:23:08PM +0300, Andy Shevchenko wrote: > On Wed, Oct 16, 2019 at 07:18:45PM +0300, Andy Shevchenko wrote: > > On Wed, Oct 16, 2019 at 09:01:26AM -0700, Dmitry Torokhov wrote: > > > On Wed, Oct 16, 2019 at 10:48:57AM +0300, Andy Shevchenko wrote: > > > > On Tue, Oct 15, 201

Re: [PATCH v5 11/14] software node: move small properties inline when copying

2019-10-16 Thread Andy Shevchenko
On Wed, Oct 16, 2019 at 07:18:45PM +0300, Andy Shevchenko wrote: > On Wed, Oct 16, 2019 at 09:01:26AM -0700, Dmitry Torokhov wrote: > > On Wed, Oct 16, 2019 at 10:48:57AM +0300, Andy Shevchenko wrote: > > > On Tue, Oct 15, 2019 at 11:25:53AM -0700, Dmitry Torokhov wrote: > > > > You store a value

Re: [PATCH v5 11/14] software node: move small properties inline when copying

2019-10-16 Thread Andy Shevchenko
On Wed, Oct 16, 2019 at 09:01:26AM -0700, Dmitry Torokhov wrote: > On Wed, Oct 16, 2019 at 10:48:57AM +0300, Andy Shevchenko wrote: > > On Tue, Oct 15, 2019 at 11:25:53AM -0700, Dmitry Torokhov wrote: > > You store a value as union, but going to read as a member of union? > > I'm pretty sure it br

Re: [PATCH v5 11/14] software node: move small properties inline when copying

2019-10-16 Thread Dmitry Torokhov
On Wed, Oct 16, 2019 at 10:48:57AM +0300, Andy Shevchenko wrote: > On Tue, Oct 15, 2019 at 11:25:53AM -0700, Dmitry Torokhov wrote: > > On Tue, Oct 15, 2019 at 03:20:28PM +0300, Andy Shevchenko wrote: > > > On Fri, Oct 11, 2019 at 04:07:18PM -0700, Dmitry Torokhov wrote: > > > > When copying/duplic

Re: [PATCH v5 11/14] software node: move small properties inline when copying

2019-10-16 Thread Andy Shevchenko
On Tue, Oct 15, 2019 at 11:25:53AM -0700, Dmitry Torokhov wrote: > On Tue, Oct 15, 2019 at 03:20:28PM +0300, Andy Shevchenko wrote: > > On Fri, Oct 11, 2019 at 04:07:18PM -0700, Dmitry Torokhov wrote: > > > When copying/duplicating set of properties, move smaller properties that > > > were stored s

Re: [PATCH v5 11/14] software node: move small properties inline when copying

2019-10-15 Thread Dmitry Torokhov
On Tue, Oct 15, 2019 at 03:20:28PM +0300, Andy Shevchenko wrote: > On Fri, Oct 11, 2019 at 04:07:18PM -0700, Dmitry Torokhov wrote: > > When copying/duplicating set of properties, move smaller properties that > > were stored separately directly inside property entry structures. We can > > move: > >

Re: [PATCH v5 11/14] software node: move small properties inline when copying

2019-10-15 Thread Andy Shevchenko
On Fri, Oct 11, 2019 at 04:07:18PM -0700, Dmitry Torokhov wrote: > When copying/duplicating set of properties, move smaller properties that > were stored separately directly inside property entry structures. We can > move: > > - up to 8 bytes from U8 arrays > - up to 4 words > - up to 2 double wor

[PATCH v5 11/14] software node: move small properties inline when copying

2019-10-11 Thread Dmitry Torokhov
When copying/duplicating set of properties, move smaller properties that were stored separately directly inside property entry structures. We can move: - up to 8 bytes from U8 arrays - up to 4 words - up to 2 double words - one U64 value - one or 2 strings. Signed-off-by: Dmitry Torokhov --- dr