Re: [PATCH v5 14/17] tpm: remove TPM_TRANSMIT_UNLOCKED flag

2018-11-08 Thread Jarkko Sakkinen
On Thu, Nov 08, 2018 at 10:43:46AM -0500, Stefan Berger wrote: > > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c > > index f2b0e5c52a57..d6abc964ef66 100644 > > --- a/drivers/char/tpm/tpm2-cmd.c > > +++ b/drivers/char/tpm/tpm2-cmd.c > > @@ -652,17 +652,12 @@ int tpm2_unseal

Re: [PATCH v5 14/17] tpm: remove TPM_TRANSMIT_UNLOCKED flag

2018-11-08 Thread Stefan Berger
On 11/8/18 9:15 AM, Jarkko Sakkinen wrote: Added locking as part of tpm_try_get_ops() and tpm_put_ops() as they are anyway used in most of the call sites except in tpmrm_release() where we take the locks manually. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 2 ++

[PATCH v5 14/17] tpm: remove TPM_TRANSMIT_UNLOCKED flag

2018-11-08 Thread Jarkko Sakkinen
Added locking as part of tpm_try_get_ops() and tpm_put_ops() as they are anyway used in most of the call sites except in tpmrm_release() where we take the locks manually. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 2 ++ drivers/char/tpm/tpm-dev-common.c | 4 +--- dr