Re: [PATCH v5 16/16] mm/userfaultfd: Honor FAULT_FLAG_KILLABLE in fault path

2019-09-29 Thread Peter Xu
On Thu, Sep 26, 2019 at 05:39:04PM +0800, Peter Xu wrote: > @@ -490,8 +512,7 @@ vm_fault_t handle_userfault(struct vm_fault *vmf, > unsigned long reason) > up_read(>mmap_sem); > > if (likely(must_wait && !READ_ONCE(ctx->released) && > -(return_to_userland ?

[PATCH v5 16/16] mm/userfaultfd: Honor FAULT_FLAG_KILLABLE in fault path

2019-09-26 Thread Peter Xu
Userfaultfd fault path was by default killable even if the caller does not have FAULT_FLAG_KILLABLE. That makes sense before in that when with gup we don't have FAULT_FLAG_KILLABLE properly set before. Now after previous patch we've got FAULT_FLAG_KILLABLE applied even for gup code so it should