Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-13 Thread Jiri Olsa
On Thu, Oct 12, 2017 at 08:52:18PM +0200, Jiri Olsa wrote: > On Thu, Oct 12, 2017 at 08:22:58PM +0200, Milian Wolff wrote: > > SNIP > > > > > return SRCLINE_UNKNOWN; > > > > > > > > - return get_srcline(map->dso, map__rip_2objdump(map, he->ip), > > > > + return

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-13 Thread Jiri Olsa
On Thu, Oct 12, 2017 at 08:52:18PM +0200, Jiri Olsa wrote: > On Thu, Oct 12, 2017 at 08:22:58PM +0200, Milian Wolff wrote: > > SNIP > > > > > return SRCLINE_UNKNOWN; > > > > > > > > - return get_srcline(map->dso, map__rip_2objdump(map, he->ip), > > > > + return

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-12 Thread Namhyung Kim
On Thu, Oct 12, 2017 at 08:22:58PM +0200, Milian Wolff wrote: > On Dienstag, 10. Oktober 2017 06:49:54 CEST Namhyung Kim wrote: > > Hi Milian, > > > > On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote: > > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > > > index

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-12 Thread Namhyung Kim
On Thu, Oct 12, 2017 at 08:22:58PM +0200, Milian Wolff wrote: > On Dienstag, 10. Oktober 2017 06:49:54 CEST Namhyung Kim wrote: > > Hi Milian, > > > > On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote: > > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > > > index

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-12 Thread Jiri Olsa
On Thu, Oct 12, 2017 at 08:22:58PM +0200, Milian Wolff wrote: SNIP > > > return SRCLINE_UNKNOWN; > > > > > > - return get_srcline(map->dso, map__rip_2objdump(map, he->ip), > > > + return get_srcline(map->dso, map__objdump_2mem(map, he->ip), > > > > > >

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-12 Thread Jiri Olsa
On Thu, Oct 12, 2017 at 08:22:58PM +0200, Milian Wolff wrote: SNIP > > > return SRCLINE_UNKNOWN; > > > > > > - return get_srcline(map->dso, map__rip_2objdump(map, he->ip), > > > + return get_srcline(map->dso, map__objdump_2mem(map, he->ip), > > > > > >

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-12 Thread Milian Wolff
On Dienstag, 10. Oktober 2017 06:49:54 CEST Namhyung Kim wrote: > Hi Milian, > > On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote: > > When inline frame resolution is disabled, a bogus srcline is obtained > > for hist entries: > > > > ~ > > $ perf report -s sym,srcline

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-12 Thread Milian Wolff
On Dienstag, 10. Oktober 2017 06:49:54 CEST Namhyung Kim wrote: > Hi Milian, > > On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote: > > When inline frame resolution is disabled, a bogus srcline is obtained > > for hist entries: > > > > ~ > > $ perf report -s sym,srcline

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-09 Thread Namhyung Kim
Hi Milian, On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote: > When inline frame resolution is disabled, a bogus srcline is obtained > for hist entries: > > ~ > $ perf report -s sym,srcline --no-inline --stdio -g none > 95.21% 0.00% [.] __libc_start_main

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-09 Thread Namhyung Kim
Hi Milian, On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote: > When inline frame resolution is disabled, a bogus srcline is obtained > for hist entries: > > ~ > $ perf report -s sym,srcline --no-inline --stdio -g none > 95.21% 0.00% [.] __libc_start_main

[PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-09 Thread Milian Wolff
When inline frame resolution is disabled, a bogus srcline is obtained for hist entries: ~ $ perf report -s sym,srcline --no-inline --stdio -g none 95.21% 0.00% [.] __libc_start_main

[PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

2017-10-09 Thread Milian Wolff
When inline frame resolution is disabled, a bogus srcline is obtained for hist entries: ~ $ perf report -s sym,srcline --no-inline --stdio -g none 95.21% 0.00% [.] __libc_start_main