Re: [PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-30 Thread Jagan Teki
On Tue, Jan 29, 2019 at 8:49 PM Sam Ravnborg wrote: > > Hi Jagan. > > > > > > > I see DRM_MODE_ARG as mode argument, that print all mode timings but > > > here we need only 3 timings out of it. do we really need? if yes > > > please suggest an example. > > > > fyi: sent v6 for this except this cha

Re: [PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-29 Thread Sam Ravnborg
Hi Jagan. > > > > I see DRM_MODE_ARG as mode argument, that print all mode timings but > > here we need only 3 timings out of it. do we really need? if yes > > please suggest an example. > > fyi: sent v6 for this except this change. Let me know if you have any > comments on this. Drivers looks f

Re: [PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-29 Thread Jagan Teki
Hi Sam, On Mon, Jan 28, 2019 at 12:41 AM Jagan Teki wrote: > > On Sat, Jan 26, 2019 at 1:22 AM Sam Ravnborg wrote: > > > > Hi Jagan. > > > > Looks good, only very few nits left. > > > > On Sat, Jan 26, 2019 at 12:52:33AM +0530, Jagan Teki wrote: > > > Feiyang FY07024DI26A30-D is 1024x600, 4-lane

Re: [PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-27 Thread Jagan Teki
On Sat, Jan 26, 2019 at 1:22 AM Sam Ravnborg wrote: > > Hi Jagan. > > Looks good, only very few nits left. > > On Sat, Jan 26, 2019 at 12:52:33AM +0530, Jagan Teki wrote: > > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > > > Add panel driver for it. > > > > Tested-by: Bhusha

Re: [PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-25 Thread Sam Ravnborg
Hi Jagan. Looks good, only very few nits left. On Sat, Jan 26, 2019 at 12:52:33AM +0530, Jagan Teki wrote: > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > Add panel driver for it. > > Tested-by: Bhushan Shah > Signed-off-by: Jagan Teki If you consider my inputs (I know

[PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-25 Thread Jagan Teki
Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. Add panel driver for it. Tested-by: Bhushan Shah Signed-off-by: Jagan Teki --- Changes for v5: - drop drmP.h header - order include files - add empty line after kzalloc() - drop gpio set for reset - drop backlight put_device from