Re: [PATCH v5 2/2] leds: lm3697: Introduce the lm3697 driver

2018-09-05 Thread Dan Murphy
Pavel On 08/24/2018 05:05 AM, Pavel Machek wrote: > Hi! > I am going to go ahead and update this code anyway and if we get the ti-lmu code in then we can adapt this code to use that framework >> +/** >> + * struct lm3697 - >> + * @enable_gpio - Hardware enable gpio >> + * @regulator - LED suppl

Re: [PATCH v5 2/2] leds: lm3697: Introduce the lm3697 driver

2018-08-24 Thread Jacek Anaszewski
Dan, On 08/24/2018 01:58 PM, Dan Murphy wrote: > Jacek > > On 08/24/2018 05:05 AM, Pavel Machek wrote: >> Hi! >> >>> +/** >>> + * struct lm3697 - >>> + * @enable_gpio - Hardware enable gpio >>> + * @regulator - LED supply regulator pointer >>> + * @client - Pointer to the I2C client >>> + * @regm

Re: [PATCH v5 2/2] leds: lm3697: Introduce the lm3697 driver

2018-08-24 Thread Dan Murphy
Jacek On 08/24/2018 05:05 AM, Pavel Machek wrote: > Hi! > >> +/** >> + * struct lm3697 - >> + * @enable_gpio - Hardware enable gpio >> + * @regulator - LED supply regulator pointer >> + * @client - Pointer to the I2C client >> + * @regmap - Devices register map >> + * @dev - Pointer to the device

Re: [PATCH v5 2/2] leds: lm3697: Introduce the lm3697 driver

2018-08-24 Thread Pavel Machek
Hi! > +/** > + * struct lm3697 - > + * @enable_gpio - Hardware enable gpio > + * @regulator - LED supply regulator pointer > + * @client - Pointer to the I2C client > + * @regmap - Devices register map > + * @dev - Pointer to the devices device struct > + * @lock - Lock for reading/writing the dev

[PATCH v5 2/2] leds: lm3697: Introduce the lm3697 driver

2018-08-17 Thread Dan Murphy
Introduce the lm3697 LED driver for backlighting and display. Datasheet location: http://www.ti.com/lit/ds/symlink/lm3697.pdf Signed-off-by: Dan Murphy --- v5 - Fix nitpick issues with code - https://lore.kernel.org/patchwork/patch/975061/ v4 - Made modifications to the control bank routine t