Re: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints

2018-06-28 Thread Keith Busch
On Thu, Jun 28, 2018 at 09:48:24AM +0200, Johannes Thumshirn wrote: > On Wed, Jun 27, 2018 at 10:37:06AM -0600, Keith Busch wrote: > > It looks like you want the # assigned to /dev/nvme<#>. Do you want to > > use ctrl->instance here instead? > > Right. > > As it'll conflict with your other trace

Re: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints

2018-06-28 Thread Keith Busch
On Thu, Jun 28, 2018 at 09:48:24AM +0200, Johannes Thumshirn wrote: > On Wed, Jun 27, 2018 at 10:37:06AM -0600, Keith Busch wrote: > > It looks like you want the # assigned to /dev/nvme<#>. Do you want to > > use ctrl->instance here instead? > > Right. > > As it'll conflict with your other trace

Re: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints

2018-06-28 Thread Johannes Thumshirn
On Wed, Jun 27, 2018 at 10:37:06AM -0600, Keith Busch wrote: > It looks like you want the # assigned to /dev/nvme<#>. Do you want to > use ctrl->instance here instead? Right. As it'll conflict with your other trace patch do you want me to wait with the resend? Johannes -- Johannes

Re: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints

2018-06-28 Thread Johannes Thumshirn
On Wed, Jun 27, 2018 at 10:37:06AM -0600, Keith Busch wrote: > It looks like you want the # assigned to /dev/nvme<#>. Do you want to > use ctrl->instance here instead? Right. As it'll conflict with your other trace patch do you want me to wait with the resend? Johannes -- Johannes

Re: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints

2018-06-27 Thread Keith Busch
On Wed, Jun 27, 2018 at 02:53:24PM +0200, Johannes Thumshirn wrote: > TP_fast_assign( > - __entry->qid = qid; > + __assign_str(name, disk_name); > + __entry->ctrl_id = nvme_req(req)->ctrl->cntlid; > + __entry->qid =

Re: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints

2018-06-27 Thread Keith Busch
On Wed, Jun 27, 2018 at 02:53:24PM +0200, Johannes Thumshirn wrote: > TP_fast_assign( > - __entry->qid = qid; > + __assign_str(name, disk_name); > + __entry->ctrl_id = nvme_req(req)->ctrl->cntlid; > + __entry->qid =

[PATCH v5 2/2] nvme: trace: add disk name to tracepoints

2018-06-27 Thread Johannes Thumshirn
Add disk name to tracepoints so we can better distinguish between individual disks in the trace output and admin commands which are represented without a disk name. Signed-off-by: Johannes Thumshirn --- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/trace.h | 39

[PATCH v5 2/2] nvme: trace: add disk name to tracepoints

2018-06-27 Thread Johannes Thumshirn
Add disk name to tracepoints so we can better distinguish between individual disks in the trace output and admin commands which are represented without a disk name. Signed-off-by: Johannes Thumshirn --- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/trace.h | 39