Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-31 Thread Eddie Huang
Hi Sascha, On Tue, 2015-03-31 at 19:52 +0200, Sascha Hauer wrote: > On Tue, Mar 31, 2015 at 07:50:58PM +0800, Eddie Huang wrote: > > Hi Sascha, > > > > On Tue, 2015-03-31 at 15:08 +0800, Eddie Huang wrote: > > > Hi Sascha, > > > > > > > > > speed <= 40 here to make this more obvious? > > >

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-31 Thread Sascha Hauer
On Tue, Mar 31, 2015 at 07:50:58PM +0800, Eddie Huang wrote: > Hi Sascha, > > On Tue, 2015-03-31 at 15:08 +0800, Eddie Huang wrote: > > Hi Sascha, > > > > > > > speed <= 40 here to make this more obvious? > > > > There are two cases, not only speed<=40, but I2C_MASTER_WRRD. I tend > > >

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-31 Thread Eddie Huang
Hi Sascha, On Tue, 2015-03-31 at 15:08 +0800, Eddie Huang wrote: > Hi Sascha, > > On Mon, 2015-03-30 at 19:23 +0200, Sascha Hauer wrote: > > On Mon, Mar 30, 2015 at 04:14:12PM +0800, Eddie Huang wrote: > > > Hi Sascha, > > > > > > > > > > > [...] > > > > > > > > > + if (i2c->speed_hz >

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-31 Thread Eddie Huang
Hi Sascha, On Mon, 2015-03-30 at 19:23 +0200, Sascha Hauer wrote: > On Mon, Mar 30, 2015 at 04:14:12PM +0800, Eddie Huang wrote: > > Hi Sascha, > > > > > > > > [...] > > > > > > > + if (i2c->speed_hz > 40) > > > > + control_reg |= I2C_CONTROL_RS; > > > > + if

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-31 Thread Eddie Huang
Hi Sascha, On Mon, 2015-03-30 at 19:23 +0200, Sascha Hauer wrote: On Mon, Mar 30, 2015 at 04:14:12PM +0800, Eddie Huang wrote: Hi Sascha, [...] + if (i2c-speed_hz 40) + control_reg |= I2C_CONTROL_RS; + if (i2c-op == I2C_MASTER_WRRD)

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-31 Thread Eddie Huang
Hi Sascha, On Tue, 2015-03-31 at 15:08 +0800, Eddie Huang wrote: Hi Sascha, On Mon, 2015-03-30 at 19:23 +0200, Sascha Hauer wrote: On Mon, Mar 30, 2015 at 04:14:12PM +0800, Eddie Huang wrote: Hi Sascha, [...] + if (i2c-speed_hz 40) +

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-31 Thread Eddie Huang
Hi Sascha, On Tue, 2015-03-31 at 19:52 +0200, Sascha Hauer wrote: On Tue, Mar 31, 2015 at 07:50:58PM +0800, Eddie Huang wrote: Hi Sascha, On Tue, 2015-03-31 at 15:08 +0800, Eddie Huang wrote: Hi Sascha, speed = 40 here to make this more obvious? There are two cases,

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-31 Thread Sascha Hauer
On Tue, Mar 31, 2015 at 07:50:58PM +0800, Eddie Huang wrote: Hi Sascha, On Tue, 2015-03-31 at 15:08 +0800, Eddie Huang wrote: Hi Sascha, speed = 40 here to make this more obvious? There are two cases, not only speed=40, but I2C_MASTER_WRRD. I tend to keep it.

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-30 Thread Sascha Hauer
On Mon, Mar 30, 2015 at 04:14:12PM +0800, Eddie Huang wrote: > Hi Sascha, > > > > > [...] > > > > > + if (i2c->speed_hz > 40) > > > + control_reg |= I2C_CONTROL_RS; > > > + if (i2c->op == I2C_MASTER_WRRD) > > > + control_reg |= I2C_CONTROL_DIR_CHANGE | I2C_CONTROL_RS; > > >

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-30 Thread Eddie Huang
Hi Sascha, On Mon, 2015-03-23 at 09:42 +0100, Sascha Hauer wrote: > On Sat, Mar 21, 2015 at 02:05:21PM +0800, Eddie Huang wrote: > > From: Xudong Chen > > > > The mediatek SoCs have I2C controller that handle I2C transfer. > > This patch include common I2C bus driver. > > This driver is

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-30 Thread Eddie Huang
Hi Sascha, On Mon, 2015-03-23 at 09:42 +0100, Sascha Hauer wrote: On Sat, Mar 21, 2015 at 02:05:21PM +0800, Eddie Huang wrote: From: Xudong Chen xudong.c...@mediatek.com The mediatek SoCs have I2C controller that handle I2C transfer. This patch include common I2C bus driver. This

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-30 Thread Sascha Hauer
On Mon, Mar 30, 2015 at 04:14:12PM +0800, Eddie Huang wrote: Hi Sascha, [...] + if (i2c-speed_hz 40) + control_reg |= I2C_CONTROL_RS; + if (i2c-op == I2C_MASTER_WRRD) + control_reg |= I2C_CONTROL_DIR_CHANGE | I2C_CONTROL_RS; +

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-23 Thread Sascha Hauer
On Sat, Mar 21, 2015 at 02:05:21PM +0800, Eddie Huang wrote: > From: Xudong Chen > > The mediatek SoCs have I2C controller that handle I2C transfer. > This patch include common I2C bus driver. > This driver is compatible with I2C controller on mt65xx/mt81xx. > > Signed-off-by: Xudong Chen >

Re: [PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-23 Thread Sascha Hauer
On Sat, Mar 21, 2015 at 02:05:21PM +0800, Eddie Huang wrote: From: Xudong Chen xudong.c...@mediatek.com The mediatek SoCs have I2C controller that handle I2C transfer. This patch include common I2C bus driver. This driver is compatible with I2C controller on mt65xx/mt81xx. Signed-off-by:

[PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-21 Thread Eddie Huang
From: Xudong Chen The mediatek SoCs have I2C controller that handle I2C transfer. This patch include common I2C bus driver. This driver is compatible with I2C controller on mt65xx/mt81xx. Signed-off-by: Xudong Chen Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang ---

[PATCH v5 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-03-21 Thread Eddie Huang
From: Xudong Chen xudong.c...@mediatek.com The mediatek SoCs have I2C controller that handle I2C transfer. This patch include common I2C bus driver. This driver is compatible with I2C controller on mt65xx/mt81xx. Signed-off-by: Xudong Chen xudong.c...@mediatek.com Signed-off-by: Liguo Zhang