Re: [PATCH v5 2/3] Input: Add Novatek NT36xxx touchscreen driver

2020-10-21 Thread dmitry . torokhov
Hi AngeloGioacchino, [obviously not a complete review, but wanted to call out regmap concern] On Sat, Oct 17, 2020 at 09:01:51PM +0200, khol...@gmail.com wrote: > +static int nt36xxx_read_pid(struct nt36xxx_i2c *ts) > +{ > + u8 buf[2] = { 0 }; __be16 pid; > + int ret = 0; > + >

Re: [PATCH v5 2/3] Input: Add Novatek NT36xxx touchscreen driver

2020-10-18 Thread Andy Shevchenko
On Sun, Oct 18, 2020 at 12:40 AM wrote: > > From: AngeloGioacchino Del Regno > > This is a driver for the Novatek in-cell touch controller and > supports various chips from the NT36xxx family, currently > including NT36525, NT36672A, NT36676F, NT36772 and NT36870. > > Functionality like wake gest

[PATCH v5 2/3] Input: Add Novatek NT36xxx touchscreen driver

2020-10-17 Thread kholk11
From: AngeloGioacchino Del Regno This is a driver for the Novatek in-cell touch controller and supports various chips from the NT36xxx family, currently including NT36525, NT36672A, NT36676F, NT36772 and NT36870. Functionality like wake gestures and firmware flashing is not included: I am not aw