Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-07-05 Thread Marc Gonzalez
On 05/07/2017 11:36, Ard Biesheuvel wrote: > On 31 May 2017 at 13:33, Marc Gonzalez wrote: > >> This driver is required to work around several hardware bugs >> in the PCIe controller. >> >> NB: Revision 1 does not support legacy interrupts, or IO space. >> >> + /* >> +* QUIRK #1 >> +

Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-07-05 Thread Ard Biesheuvel
On 31 May 2017 at 13:33, Marc Gonzalez wrote: > This driver is required to work around several hardware bugs > in the PCIe controller. > > NB: Revision 1 does not support legacy interrupts, or IO space. > > Signed-off-by: Marc Gonzalez > --- > drivers/pci/host/Kconfig | 8 +++ > drivers/p

Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-06-20 Thread Marc Gonzalez
On 19/06/2017 16:50, Marc Gonzalez wrote: > On 07/06/2017 10:19, Marc Gonzalez wrote: > >> On 31/05/2017 15:33, Marc Gonzalez wrote: >> >>> +static int tango_pcie_probe(struct platform_device *pdev) >>> +{ >>> + int ret = -EINVAL; >>> + void __iomem *base; >>> + struct resource *res; >>> +

Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-06-19 Thread Marc Zyngier
On 19/06/17 17:01, Marc Gonzalez wrote: > On 19/06/2017 17:58, Marc Zyngier wrote: >> On 19/06/17 15:50, Marc Gonzalez wrote: >>> On 07/06/2017 10:19, Marc Gonzalez wrote: >>> On 31/05/2017 15:33, Marc Gonzalez wrote: > +static int tango_pcie_probe(struct platform_device *pdev) >

Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-06-19 Thread Marc Gonzalez
On 19/06/2017 17:58, Marc Zyngier wrote: > On 19/06/17 15:50, Marc Gonzalez wrote: >> On 07/06/2017 10:19, Marc Gonzalez wrote: >> >>> On 31/05/2017 15:33, Marc Gonzalez wrote: >>> +static int tango_pcie_probe(struct platform_device *pdev) +{ + int ret = -EINVAL; + void __iome

Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-06-19 Thread Marc Zyngier
On 19/06/17 15:50, Marc Gonzalez wrote: > On 07/06/2017 10:19, Marc Gonzalez wrote: > >> On 31/05/2017 15:33, Marc Gonzalez wrote: >> >>> +static int tango_pcie_probe(struct platform_device *pdev) >>> +{ >>> + int ret = -EINVAL; >>> + void __iomem *base; >>> + struct resource *res; >>> + s

Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-06-19 Thread Marc Gonzalez
On 07/06/2017 10:19, Marc Gonzalez wrote: > On 31/05/2017 15:33, Marc Gonzalez wrote: > >> +static int tango_pcie_probe(struct platform_device *pdev) >> +{ >> +int ret = -EINVAL; >> +void __iomem *base; >> +struct resource *res; >> +struct tango_pcie *pcie; >> +struct device *

Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-06-07 Thread Marc Gonzalez
On 31/05/2017 15:33, Marc Gonzalez wrote: > +static int tango_pcie_probe(struct platform_device *pdev) > +{ > + int ret = -EINVAL; > + void __iomem *base; > + struct resource *res; > + struct tango_pcie *pcie; > + struct device *dev = &pdev->dev; > + > + pr_err("MAJOR ISSUE

[PATCH v5 2/3] PCI: Add tango PCIe host bridge support

2017-05-31 Thread Marc Gonzalez
This driver is required to work around several hardware bugs in the PCIe controller. NB: Revision 1 does not support legacy interrupts, or IO space. Signed-off-by: Marc Gonzalez --- drivers/pci/host/Kconfig | 8 +++ drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-tango.c | 1