Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-11-04 Thread Jianxin Pan
Hi Stephen, Thank you for the review. On 2018/11/4 11:04, Stephen Boyd wrote: > Quoting Yixun Lan (2018-10-25 00:29:15) >> yes, I think the documentation need to be fixed >> >> for the final solution, we decide to make 'mmc-clkc' an independent node >> instead of being a sub-node of 'mmc', so

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-11-04 Thread Jianxin Pan
Hi Stephen, Thank you for the review. On 2018/11/4 11:04, Stephen Boyd wrote: > Quoting Yixun Lan (2018-10-25 00:29:15) >> yes, I think the documentation need to be fixed >> >> for the final solution, we decide to make 'mmc-clkc' an independent node >> instead of being a sub-node of 'mmc', so

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-11-03 Thread Stephen Boyd
Quoting Yixun Lan (2018-10-25 00:29:15) > yes, I think the documentation need to be fixed > > for the final solution, we decide to make 'mmc-clkc' an independent node > instead of being a sub-node of 'mmc', so both of them may exist in parallel.. > > the DT part may like this: > >

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-11-03 Thread Stephen Boyd
Quoting Yixun Lan (2018-10-25 00:29:15) > yes, I think the documentation need to be fixed > > for the final solution, we decide to make 'mmc-clkc' an independent node > instead of being a sub-node of 'mmc', so both of them may exist in parallel.. > > the DT part may like this: > >

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-25 Thread Jianxin Pan
On 2018/10/25 15:29, Yixun Lan wrote: > Hi Jerome, Jianxin: > > see my comments > > On 10:58 Wed 24 Oct , Jerome Brunet wrote: >> On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: >>> From: Yixun Lan >>> >>> Document the MMC sub clock controller driver, the potential consumer >>> of

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-25 Thread Jianxin Pan
On 2018/10/25 15:29, Yixun Lan wrote: > Hi Jerome, Jianxin: > > see my comments > > On 10:58 Wed 24 Oct , Jerome Brunet wrote: >> On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: >>> From: Yixun Lan >>> >>> Document the MMC sub clock controller driver, the potential consumer >>> of

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-25 Thread Yixun Lan
Hi Jerome, Jianxin: see my comments On 10:58 Wed 24 Oct , Jerome Brunet wrote: > On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > > From: Yixun Lan > > > > Document the MMC sub clock controller driver, the potential consumer > > of this driver is MMC or NAND. Also add four clock

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-25 Thread Yixun Lan
Hi Jerome, Jianxin: see my comments On 10:58 Wed 24 Oct , Jerome Brunet wrote: > On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > > From: Yixun Lan > > > > Document the MMC sub clock controller driver, the potential consumer > > of this driver is MMC or NAND. Also add four clock

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-24 Thread Jerome Brunet
On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > From: Yixun Lan > > Document the MMC sub clock controller driver, the potential consumer > of this driver is MMC or NAND. Also add four clock bindings IDs which > provided by this driver. > > Reviewed-by: Rob Herring > Signed-off-by:

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-24 Thread Jerome Brunet
On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > From: Yixun Lan > > Document the MMC sub clock controller driver, the potential consumer > of this driver is MMC or NAND. Also add four clock bindings IDs which > provided by this driver. > > Reviewed-by: Rob Herring > Signed-off-by:

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-22 Thread Jianxin Pan
Hi Stephen, Thanks for the fully review, we really appreciate your time. Please see my comments below. On 2018/10/20 2:04, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-19 08:50:08) >> On 2018/10/19 1:08, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:24) diff --git

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-22 Thread Jianxin Pan
Hi Stephen, Thanks for the fully review, we really appreciate your time. Please see my comments below. On 2018/10/20 2:04, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-19 08:50:08) >> On 2018/10/19 1:08, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:24) diff --git

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-19 Thread Stephen Boyd
Quoting Jianxin Pan (2018-10-19 08:50:08) > On 2018/10/19 1:08, Stephen Boyd wrote: > > Quoting Jianxin Pan (2018-10-17 22:07:24) > >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > >> b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > >> new file mode

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-19 Thread Stephen Boyd
Quoting Jianxin Pan (2018-10-19 08:50:08) > On 2018/10/19 1:08, Stephen Boyd wrote: > > Quoting Jianxin Pan (2018-10-17 22:07:24) > >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > >> b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > >> new file mode

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-19 Thread Jianxin Pan
On 2018/10/19 1:08, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-17 22:07:24) >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt >> b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt >> new file mode 100644 >> index 000..9e6d343 >> --- /dev/null >>

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-19 Thread Jianxin Pan
On 2018/10/19 1:08, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-17 22:07:24) >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt >> b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt >> new file mode 100644 >> index 000..9e6d343 >> --- /dev/null >>

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-18 Thread Stephen Boyd
Quoting Jianxin Pan (2018-10-17 22:07:24) > diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > new file mode 100644 > index 000..9e6d343 > --- /dev/null > +++

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-18 Thread Stephen Boyd
Quoting Jianxin Pan (2018-10-17 22:07:24) > diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > new file mode 100644 > index 000..9e6d343 > --- /dev/null > +++

[PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-17 Thread Jianxin Pan
From: Yixun Lan Document the MMC sub clock controller driver, the potential consumer of this driver is MMC or NAND. Also add four clock bindings IDs which provided by this driver. Reviewed-by: Rob Herring Signed-off-by: Yixun Lan Signed-off-by: Jianxin Pan ---

[PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-17 Thread Jianxin Pan
From: Yixun Lan Document the MMC sub clock controller driver, the potential consumer of this driver is MMC or NAND. Also add four clock bindings IDs which provided by this driver. Reviewed-by: Rob Herring Signed-off-by: Yixun Lan Signed-off-by: Jianxin Pan ---