Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-19 Thread Ray Jui
On 1/18/2015 4:13 AM, Arend van Spriel wrote: > On 01/18/15 12:56, Uwe Kleine-König wrote: >> Hello, >> >> On Sun, Jan 18, 2015 at 12:46:51PM +0100, Arend van Spriel wrote: >>> On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100,

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-19 Thread Ray Jui
On 1/18/2015 4:13 AM, Arend van Spriel wrote: On 01/18/15 12:56, Uwe Kleine-König wrote: Hello, On Sun, Jan 18, 2015 at 12:46:51PM +0100, Arend van Spriel wrote: On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/18/15 12:56, Uwe Kleine-König wrote: Hello, On Sun, Jan 18, 2015 at 12:46:51PM +0100, Arend van Spriel wrote: On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
Hello, On Sun, Jan 18, 2015 at 12:46:51PM +0100, Arend van Spriel wrote: > On 01/18/15 12:17, Uwe Kleine-König wrote: > >Hello Wolfram, > > > >On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: > >>On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: > >>>On Sun, Jan 18,

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: On 01/17/15 00:42, Ray Jui wrote: +

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Wolfram Sang
On Sun, Jan 18, 2015 at 12:17:59PM +0100, Uwe Kleine-König wrote: > Hello Wolfram, > > On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: > > On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: > > > On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: > > >

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: > On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: > > On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: > > > On 01/17/15 00:42, Ray Jui wrote: > > > >+complete_all(_i2c->done);

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Wolfram Sang
On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: > Hello, > > On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: > > On 01/17/15 00:42, Ray Jui wrote: > > > > [...] > > > > >+/* > > >+ * Can be expanded in the future if more interrupt status bits are > >

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
Hello, On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: > On 01/17/15 00:42, Ray Jui wrote: > > [...] > > >+/* > >+ * Can be expanded in the future if more interrupt status bits are utilized > >+ */ > >+#define ISR_MASK (1<< IS_M_START_BUSY_SHIFT) > >+ > >+static irqreturn_t

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/17/15 00:42, Ray Jui wrote: [...] +/* + * Can be expanded in the future if more interrupt status bits are utilized + */ +#define ISR_MASK (1<< IS_M_START_BUSY_SHIFT) + +static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data) +{ + struct bcm_iproc_i2c_dev *iproc_i2c = data; +

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
Hello, On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: On 01/17/15 00:42, Ray Jui wrote: [...] +/* + * Can be expanded in the future if more interrupt status bits are utilized + */ +#define ISR_MASK (1 IS_M_START_BUSY_SHIFT) + +static irqreturn_t

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: On 01/17/15 00:42, Ray Jui wrote: +complete_all(iproc_i2c-done);

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: On 01/17/15 00:42, Ray Jui wrote: +

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Wolfram Sang
On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: Hello, On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: On 01/17/15 00:42, Ray Jui wrote: [...] +/* + * Can be expanded in the future if more interrupt status bits are utilized + */ +#define

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Wolfram Sang
On Sun, Jan 18, 2015 at 12:17:59PM +0100, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: On

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/18/15 12:56, Uwe Kleine-König wrote: Hello, On Sun, Jan 18, 2015 at 12:46:51PM +0100, Arend van Spriel wrote: On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/17/15 00:42, Ray Jui wrote: [...] +/* + * Can be expanded in the future if more interrupt status bits are utilized + */ +#define ISR_MASK (1 IS_M_START_BUSY_SHIFT) + +static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data) +{ + struct bcm_iproc_i2c_dev *iproc_i2c = data; +

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
Hello, On Sun, Jan 18, 2015 at 12:46:51PM +0100, Arend van Spriel wrote: On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: On Sun, Jan 18, 2015 at

[PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-16 Thread Ray Jui
Add initial support to the Broadcom iProc I2C controller found in the iProc family of SoCs. The iProc I2C controller has separate internal TX and RX FIFOs, each has a size of 64 bytes. The iProc I2C controller supports two bus speeds including standard mode (100kHz) and fast mode (400kHz)

[PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-16 Thread Ray Jui
Add initial support to the Broadcom iProc I2C controller found in the iProc family of SoCs. The iProc I2C controller has separate internal TX and RX FIFOs, each has a size of 64 bytes. The iProc I2C controller supports two bus speeds including standard mode (100kHz) and fast mode (400kHz)