Re: [PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device

2019-06-17 Thread Sagar Kadam
Hello Joe, Thanks for reviewing the patch. On Tue, Jun 18, 2019 at 5:55 AM Joe Perches wrote: > > On Mon, 2019-06-17 at 21:10 +0530, Sagar Kadam wrote: > > On Sun, Jun 16, 2019 at 6:35 PM Vignesh Raghavendra wrote: > [] > > > > +static int issi_unlock(struct spi_nor *nor, loff_t ofs, uint64_t

Re: [PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device

2019-06-17 Thread Joe Perches
On Mon, 2019-06-17 at 21:10 +0530, Sagar Kadam wrote: > On Sun, Jun 16, 2019 at 6:35 PM Vignesh Raghavendra wrote: [] > > > +static int issi_unlock(struct spi_nor *nor, loff_t ofs, uint64_t len) > > > +{ [] > > > + if (ret > 0 && !(ret & mask)) { > > > + dev_info(nor->dev, > > > +

Re: [PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device

2019-06-17 Thread Sagar Kadam
Hello Vignesh, On Sun, Jun 16, 2019 at 6:35 PM Vignesh Raghavendra wrote: > > > > On 12-Jun-19 4:17 PM, Sagar Shrikant Kadam wrote: > > Nor device (is25wp256 mounted on HiFive unleashed Rev A00 board) from ISSI > > have memory blocks guarded by block protection bits BP[0,1,2,3]. > > > > Clearing

Re: [PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device

2019-06-16 Thread Vignesh Raghavendra
On 12-Jun-19 4:17 PM, Sagar Shrikant Kadam wrote: > Nor device (is25wp256 mounted on HiFive unleashed Rev A00 board) from ISSI > have memory blocks guarded by block protection bits BP[0,1,2,3]. > > Clearing block protection bits,unlocks the flash memory regions > The unlock scheme is

[PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device

2019-06-12 Thread Sagar Shrikant Kadam
Nor device (is25wp256 mounted on HiFive unleashed Rev A00 board) from ISSI have memory blocks guarded by block protection bits BP[0,1,2,3]. Clearing block protection bits,unlocks the flash memory regions The unlock scheme is registered during nor scans. Based on code developed by Wesley Terpstra