Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-04-22 Thread Liviu Dudau
On Thu, Apr 17, 2014 at 02:24:34AM +0100, Jason Gunthorpe wrote: > On Thu, Apr 17, 2014 at 01:20:42AM +0100, Liviu Dudau wrote: > > > > No spec says you can put config space into the ranges at all, nobody > > > should be doing that today, obviously some cases were missed during > > > review.. > >

Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-04-16 Thread Jason Gunthorpe
On Thu, Apr 17, 2014 at 01:20:42AM +0100, Liviu Dudau wrote: > > No spec says you can put config space into the ranges at all, nobody > > should be doing that today, obviously some cases were missed during > > review.. > > ePAPR documents allows that when ss == 00. Which do you mean? The 'PCI Bu

Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-04-16 Thread Liviu Dudau
On Wed, Apr 16, 2014 at 03:21:04PM -0600, Jason Gunthorpe wrote: > On Wed, Apr 16, 2014 at 06:05:45PM +0100, Liviu Dudau wrote: > > > I have found out that we cannot pasd the config ranges from the DT into the > > pci_host_bridge structure as the PCI framework doesn't have a resource type > > for

Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-04-16 Thread Jason Gunthorpe
On Wed, Apr 16, 2014 at 06:05:45PM +0100, Liviu Dudau wrote: > I have found out that we cannot pasd the config ranges from the DT into the > pci_host_bridge structure as the PCI framework doesn't have a resource type > for config resources. Leaving the translation between range flags and > resourc

Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-04-16 Thread Liviu Dudau
On Wed, Mar 26, 2014 at 09:28:42AM -0500, Rob Herring wrote: > On Wed, Mar 19, 2014 at 6:12 PM, Tanmay Inamdar wrote: > > This patch adds the device tree nodes for APM X-Gene PCIe controller and > > PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts > > nodes are added. > > [s

Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-03-26 Thread Jason Gunthorpe
On Wed, Mar 26, 2014 at 09:28:42AM -0500, Rob Herring wrote: > Where is the right place for config space? This binding has it here > and others have it in ranges. I think all the drivers in drivers/pci/host use 'reg', this was discussed in the dt-bindings list and AFAIK no new drivers have used

Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-03-26 Thread Liviu Dudau
On Wed, Mar 26, 2014 at 02:28:42PM +, Rob Herring wrote: > On Wed, Mar 19, 2014 at 6:12 PM, Tanmay Inamdar wrote: > > This patch adds the device tree nodes for APM X-Gene PCIe controller and > > PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts > > nodes are added. > > [s

Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-03-26 Thread Rob Herring
On Wed, Mar 19, 2014 at 6:12 PM, Tanmay Inamdar wrote: > This patch adds the device tree nodes for APM X-Gene PCIe controller and > PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts > nodes are added. [snip] > + pcie0: pcie@1f2b { > +

[PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-03-19 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts |8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 155 +++