Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code

2021-04-09 Thread Andy Shevchenko
On Fri, Apr 9, 2021 at 10:38 AM Zev Weiss wrote: > > On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote: > >On Thursday, April 8, 2021, Zev Weiss wrote: > > > >> This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions > >> out of the sysfs store functions in preparation f

Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote: On Thursday, April 8, 2021, Zev Weiss wrote: This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions out of the sysfs store functions in preparation for adding DT properties that will be poking the same registers. Wh

Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:06:16AM CDT, Andrew Jeffery wrote: On Thu, 8 Apr 2021, at 10:46, Zev Weiss wrote: This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions out of the sysfs store functions in preparation for adding DT properties that will be poking the same registers. W

Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code

2021-04-08 Thread Andrew Jeffery
On Thu, 8 Apr 2021, at 10:46, Zev Weiss wrote: > This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions > out of the sysfs store functions in preparation for adding DT > properties that will be poking the same registers. While we're at it, > these functions now provide some basic

[PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code

2021-04-07 Thread Zev Weiss
This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions out of the sysfs store functions in preparation for adding DT properties that will be poking the same registers. While we're at it, these functions now provide some basic bounds-checking on their arguments. Signed-off-by: Zev W