Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-22 Thread Anatolij Gustschin
Hi Matthew, On Wed, 22 Mar 2017 09:08:18 -0700 (PDT) matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... >> Can we also add a function for registering a PCIe device with >> PR IP here? Something like: > >If we have an alt_pr_pcie_register function, we will need the

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-22 Thread Anatolij Gustschin
Hi Matthew, On Wed, 22 Mar 2017 09:08:18 -0700 (PDT) matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... >> Can we also add a function for registering a PCIe device with >> PR IP here? Something like: > >If we have an alt_pr_pcie_register function, we will need the

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-22 Thread matthew . gerlach
On Tue, 21 Mar 2017, Anatolij Gustschin wrote: Hi Matthew, Hi Anatolij, On Fri, 10 Mar 2017 11:40:25 -0800 matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... +int alt_pr_unregister(struct device *dev) +{ + dev_dbg(dev, "%s\n", __func__); + +

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-22 Thread matthew . gerlach
On Tue, 21 Mar 2017, Anatolij Gustschin wrote: Hi Matthew, Hi Anatolij, On Fri, 10 Mar 2017 11:40:25 -0800 matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... +int alt_pr_unregister(struct device *dev) +{ + dev_dbg(dev, "%s\n", __func__); + +

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-21 Thread Anatolij Gustschin
Hi Matthew, On Fri, 10 Mar 2017 11:40:25 -0800 matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... >+int alt_pr_unregister(struct device *dev) >+{ >+ dev_dbg(dev, "%s\n", __func__); >+ >+ fpga_mgr_unregister(dev); >+ >+ return 0; >+}

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-21 Thread Anatolij Gustschin
Hi Matthew, On Fri, 10 Mar 2017 11:40:25 -0800 matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... >+int alt_pr_unregister(struct device *dev) >+{ >+ dev_dbg(dev, "%s\n", __func__); >+ >+ fpga_mgr_unregister(dev); >+ >+ return 0; >+}

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-20 Thread matthew . gerlach
On Sat, 18 Mar 2017, Anatolij Gustschin wrote: Hi Matthew, Hi Anatolij, More good feedback. See below. thanks for the patches. Please see some comments below. On Fri, 10 Mar 2017 11:40:25 -0800 matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... + if

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-20 Thread matthew . gerlach
On Sat, 18 Mar 2017, Anatolij Gustschin wrote: Hi Matthew, Hi Anatolij, More good feedback. See below. thanks for the patches. Please see some comments below. On Fri, 10 Mar 2017 11:40:25 -0800 matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... + if

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-18 Thread Anatolij Gustschin
Hi Matthew, thanks for the patches. Please see some comments below. On Fri, 10 Mar 2017 11:40:25 -0800 matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... >+ if (!(info->flags & FPGA_MGR_PARTIAL_RECONFIG)) { >+ pr_err("%s Partial Reconfiguration flag not

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-18 Thread Anatolij Gustschin
Hi Matthew, thanks for the patches. Please see some comments below. On Fri, 10 Mar 2017 11:40:25 -0800 matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote: ... >+ if (!(info->flags & FPGA_MGR_PARTIAL_RECONFIG)) { >+ pr_err("%s Partial Reconfiguration flag not

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-13 Thread Moritz Fischer
On Fri, Mar 10, 2017 at 11:40 AM, wrote: > From: Matthew Gerlach > > Adding the core functions necessary for a fpga-mgr driver > for the Altera Partial IP component. It is intended for > these functions to be used by the various

Re: [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-13 Thread Moritz Fischer
On Fri, Mar 10, 2017 at 11:40 AM, wrote: > From: Matthew Gerlach > > Adding the core functions necessary for a fpga-mgr driver > for the Altera Partial IP component. It is intended for > these functions to be used by the various bus implementations > like the platform bus or the PCIe bus. > >

[PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-10 Thread matthew . gerlach
From: Matthew Gerlach Adding the core functions necessary for a fpga-mgr driver for the Altera Partial IP component. It is intended for these functions to be used by the various bus implementations like the platform bus or the PCIe bus. Signed-off-by: Matthew

[PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-03-10 Thread matthew . gerlach
From: Matthew Gerlach Adding the core functions necessary for a fpga-mgr driver for the Altera Partial IP component. It is intended for these functions to be used by the various bus implementations like the platform bus or the PCIe bus. Signed-off-by: Matthew Gerlach --- v5: Fix comment