On Tue, Oct 20, 2020 at 7:29 AM Bjorn Andersson
wrote:
> On Sun 18 Oct 15:12 CDT 2020, Andy Shevchenko wrote:
> > On Sat, Oct 17, 2020 at 8:41 AM Bjorn Andersson
> > wrote:
...
> > > +static int lpg_lut_store(struct lpg *lpg, struct led_pattern *pattern,
> > > +size_t le
Hi!
> I was trying to use obviously bogus numbers to make you to specify
> which patches you reviewed :-).
A now that makes much more sense.
I reviewed patch 2.
Tho from the quick look i dont see anything wrong with the DTS changes either.
Hi!
> > Good way to say that is "Patches 7 and 28, Reviewed-by:"...
>
> 7 and 28 ? I dont see any patches 7 and 28 (I assume thats a typo for 8)
>
> Either way.
>
> Reviewed-by: Martin Botka
I was trying to use obviously bogus numbers to make you to specify
which patches you reviewed :-).
> Good way to say that is "Patches 7 and 28, Reviewed-by:"...
7 and 28 ? I dont see any patches 7 and 28 (I assume thats a typo for 8)
Either way.
Reviewed-by: Martin Botka
Hi!
> With the changes done to in V5 i have nothing to add.
Good way to say that is "Patches 7 and 28, Reviewed-by:"...
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
signature.asc
Description: PGP signature
On Sun 18 Oct 15:12 CDT 2020, Andy Shevchenko wrote:
> On Sat, Oct 17, 2020 at 8:41 AM Bjorn Andersson
> wrote:
> >
> > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of
> > PMICs from Qualcomm. It can operate on fixed parameters or based on a
> > lookup-table, altering the
On Sat, Oct 17, 2020 at 8:41 AM Bjorn Andersson
wrote:
>
> The Light Pulse Generator (LPG) is a PWM-block found in a wide range of
> PMICs from Qualcomm. It can operate on fixed parameters or based on a
> lookup-table, altering the duty cycle over time - which provides the
> means for e.g. hardwar
With the changes done to in V5 i have nothing to add.
The Light Pulse Generator (LPG) is a PWM-block found in a wide range of
PMICs from Qualcomm. It can operate on fixed parameters or based on a
lookup-table, altering the duty cycle over time - which provides the
means for e.g. hardware assisted transitions of LED brightness.
Signed-off-by: Bjorn An
9 matches
Mail list logo
