Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread David Howells
Herbert Xu wrote: > > No idea. It seems straightforward enough, at least on the keyrings side, > > that > > I was going to add it. > > In that case please wait for the discussion on how we handle curves > to be finalised. Sure. Will do. David

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread Herbert Xu
On Tue, Feb 02, 2021 at 09:33:23AM +, David Howells wrote: > > No idea. It seems straightforward enough, at least on the keyrings side, that > I was going to add it. In that case please wait for the discussion on how we handle curves to be finalised. Thanks, -- Email: Herbert Xu Home Page:

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread David Howells
Herbert Xu wrote: > > Should I defer it till the next merge window? > > Is there any specific reason why this has to be in the current > one? No idea. It seems straightforward enough, at least on the keyrings side, that I was going to add it. David

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread Herbert Xu
On Tue, Feb 02, 2021 at 08:27:35AM +, David Howells wrote: > > Should I defer it till the next merge window? Is there any specific reason why this has to be in the current one? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread David Howells
Herbert Xu wrote: > > Herbert wants the first patch to go through the crypto tree. Maybe all of > > them should proceed by that route if Herbert is willing? > > I'm not actually all that fussed about where it goes through. It's > just the first patch happens to touch an area that is still unde

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-01 Thread Herbert Xu
On Mon, Feb 01, 2021 at 03:07:35PM +, David Howells wrote: > > Herbert wants the first patch to go through the crypto tree. Maybe all of > them should proceed by that route if Herbert is willing? I'm not actually all that fussed about where it goes through. It's just the first patch happens

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-01 Thread Mimi Zohar
On Mon, 2021-02-01 at 09:35 -0500, Stefan Berger wrote: > On 2/1/21 8:23 AM, David Howells wrote: > > Stefan Berger wrote: > > > >> From: Stefan Berger > >> > >> Detect whether a key is an sm2 type of key by its OID in the parameters > >> array rather than assuming that everything under OID_id_ec

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-01 Thread David Howells
Mimi Zohar wrote: > > > Do you have a branch you want me to pull or did you want me to take just > > > patches 2-4? > > > > Please take it from the mailing list. If there are requests for more > > changes on the crypto level, I will send another series. I personally am > > waiting for some sor

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-01 Thread Stefan Berger
On 2/1/21 8:23 AM, David Howells wrote: Stefan Berger wrote: From: Stefan Berger Detect whether a key is an sm2 type of key by its OID in the parameters array rather than assuming that everything under OID_id_ecPublicKey is sm2, which is not the case. Signed-off-by: Stefan Berger Cc: David

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-01 Thread David Howells
Stefan Berger wrote: > From: Stefan Berger > > Detect whether a key is an sm2 type of key by its OID in the parameters > array rather than assuming that everything under OID_id_ecPublicKey > is sm2, which is not the case. > > Signed-off-by: Stefan Berger > Cc: David Howells > Cc: keyri...@vg