Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-26 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-25 02:43:00) > On Fri, Jan 23, 2015 at 10:32:13AM +, Andri Yngvason wrote: > > Quoting Ahmed S. Darwish (2015-01-23 06:07:34) > > > On Wed, Jan 21, 2015 at 05:13:45PM +0100, Wolfgang Grandegger wrote: > > > > On Wed, 21 Jan 2015 10:36:47 -0500, "Ahmed S. Darwis

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-24 Thread Ahmed S. Darwish
Hi! On Wed, Jan 21, 2015 at 04:20:25PM +, Andri Yngvason wrote: > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > > From: Ahmed S. Darwish > > > > Replace most of the can interface's state and error counters > > handling with the new can-dev can_change_state() mechanism. > > > > Suggested-

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-24 Thread Ahmed S. Darwish
On Thu, Jan 22, 2015 at 10:14:47AM +, Andri Yngvason wrote: > Quoting Marc Kleine-Budde (2015-01-21 22:59:23) > > On 01/21/2015 05:20 PM, Andri Yngvason wrote: > > > Marc, could you merge the "move bus_off++" patch before you merge this so > > > that I > > > won't have to incorporate this patc

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-24 Thread Ahmed S. Darwish
On Fri, Jan 23, 2015 at 10:32:13AM +, Andri Yngvason wrote: > Quoting Ahmed S. Darwish (2015-01-23 06:07:34) > > On Wed, Jan 21, 2015 at 05:13:45PM +0100, Wolfgang Grandegger wrote: > > > On Wed, 21 Jan 2015 10:36:47 -0500, "Ahmed S. Darwish" > > > wrote: > > > > On Wed, Jan 21, 2015 at 03:00:

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-23 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-23 06:07:34) > On Wed, Jan 21, 2015 at 05:13:45PM +0100, Wolfgang Grandegger wrote: > > On Wed, 21 Jan 2015 10:36:47 -0500, "Ahmed S. Darwish" > > wrote: > > > On Wed, Jan 21, 2015 at 03:00:15PM +, Andri Yngvason wrote: > > >> Quoting Ahmed S. Darwish (2015-01

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-22 Thread Ahmed S. Darwish
On Wed, Jan 21, 2015 at 05:13:45PM +0100, Wolfgang Grandegger wrote: > On Wed, 21 Jan 2015 10:36:47 -0500, "Ahmed S. Darwish" > wrote: > > On Wed, Jan 21, 2015 at 03:00:15PM +, Andri Yngvason wrote: > >> Quoting Ahmed S. Darwish (2015-01-21 14:43:23) > >> > Hi! > > > > ... > > > >> > <-- Unp

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-22 Thread Andri Yngvason
Quoting Marc Kleine-Budde (2015-01-21 22:59:23) > On 01/21/2015 05:20 PM, Andri Yngvason wrote: > > Marc, could you merge the "move bus_off++" patch before you merge this so > > that I > > won't have to incorporate this patch-set into it? > > ...included in the lastest pull-request to David. Use

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Marc Kleine-Budde
On 01/21/2015 05:20 PM, Andri Yngvason wrote: > Marc, could you merge the "move bus_off++" patch before you merge this so > that I > won't have to incorporate this patch-set into it? ...included in the lastest pull-request to David. Use tags/linux-can-next-for-3.20-20150121 of the can-next repo a

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-21 15:36:47) > On Wed, Jan 21, 2015 at 03:00:15PM +, Andri Yngvason wrote: > > Quoting Ahmed S. Darwish (2015-01-21 14:43:23) > > > Hi! > > ... > > > > <-- Unplug the cable --> > > > > > > (000.009106) can0 2080 [8] 00 00 00 00 00 00 08 00 ERRORF

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > From: Ahmed S. Darwish > > Replace most of the can interface's state and error counters > handling with the new can-dev can_change_state() mechanism. > > Suggested-by: Andri Yngvason > Signed-off-by: Ahmed S. Darwish > --- > drivers/net/can/usb

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Wolfgang Grandegger
On Wed, 21 Jan 2015 10:36:47 -0500, "Ahmed S. Darwish" wrote: > On Wed, Jan 21, 2015 at 03:00:15PM +, Andri Yngvason wrote: >> Quoting Ahmed S. Darwish (2015-01-21 14:43:23) >> > Hi! > > ... > >> > <-- Unplug the cable --> >> > >> > (000.009106) can0 2080 [8] 00 00 00 00 00 00 08

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Ahmed S. Darwish
On Wed, Jan 21, 2015 at 03:00:15PM +, Andri Yngvason wrote: > Quoting Ahmed S. Darwish (2015-01-21 14:43:23) > > Hi! ... > > <-- Unplug the cable --> > > > > (000.009106) can0 2080 [8] 00 00 00 00 00 00 08 00 ERRORFRAME > > bus-error > > error-counter-tx-rx{{8}{0}

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-21 14:43:23) > Hi! > > On Wed, Jan 21, 2015 at 12:53:58PM +0100, Wolfgang Grandegger wrote: > > On Wed, 21 Jan 2015 10:33:19 +, Andri Yngvason > > wrote: > > > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > > >> From: Ahmed S. Darwish > > >> > > >> Replac

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Ahmed S. Darwish
Hi! On Wed, Jan 21, 2015 at 12:53:58PM +0100, Wolfgang Grandegger wrote: > On Wed, 21 Jan 2015 10:33:19 +, Andri Yngvason > wrote: > > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > >> From: Ahmed S. Darwish > >> > >> Replace most of the can interface's state and error counters > >> handl

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Wolfgang Grandegger
On Wed, 21 Jan 2015 10:33:19 +, Andri Yngvason wrote: > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) >> From: Ahmed S. Darwish >> >> Replace most of the can interface's state and error counters >> handling with the new can-dev can_change_state() mechanism. >> >> Suggested-by: Andri Yngvas

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Marc Kleine-Budde (2015-01-21 10:44:54) > On 01/21/2015 11:33 AM, Andri Yngvason wrote: > > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > >> From: Ahmed S. Darwish > >> > >> Replace most of the can interface's state and error counters > >> handling with the new can-dev can_change_state(

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > From: Ahmed S. Darwish > > Replace most of the can interface's state and error counters > handling with the new can-dev can_change_state() mechanism. > > Suggested-by: Andri Yngvason > Signed-off-by: Ahmed S. Darwish > --- > drivers/net/can/usb

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Marc Kleine-Budde
On 01/21/2015 11:33 AM, Andri Yngvason wrote: > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) >> From: Ahmed S. Darwish >> >> Replace most of the can interface's state and error counters >> handling with the new can-dev can_change_state() mechanism. >> >> Suggested-by: Andri Yngvason >> Signed-o

[PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-20 Thread Ahmed S. Darwish
From: Ahmed S. Darwish Replace most of the can interface's state and error counters handling with the new can-dev can_change_state() mechanism. Suggested-by: Andri Yngvason Signed-off-by: Ahmed S. Darwish --- drivers/net/can/usb/kvaser_usb.c | 114 +++ 1 fi