Re: [PATCH v5 2/5] tracing: Rework synthetic event command parsing

On Wed, 23 Dec 2020 17:17:27 -0600 Tom Zanussi wrote: > Hi Masami, > > On Tue, 2020-12-22 at 21:42 +0900, Masami Hiramatsu wrote: > > Hi Tom, > > > > On Mon, 21 Dec 2020 15:44:28 -0600 > > Tom Zanussi wrote: > > > > > > > @@ -656,7 +651,6 @@ static struct synth_field > > > *parse_synth_field

Re: [PATCH v5 2/5] tracing: Rework synthetic event command parsing

Hi Masami, On Tue, 2020-12-22 at 21:42 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Mon, 21 Dec 2020 15:44:28 -0600 > Tom Zanussi wrote: > > > > @@ -656,7 +651,6 @@ static struct synth_field > > *parse_synth_field(int argc, const char **argv, > > > > size = synth_field_size(field->typ

Re: [PATCH v5 2/5] tracing: Rework synthetic event command parsing

Hi Tom, On Mon, 21 Dec 2020 15:44:28 -0600 Tom Zanussi wrote: > @@ -656,7 +651,6 @@ static struct synth_field *parse_synth_field(int argc, > const char **argv, > > size = synth_field_size(field->type); > if (size < 0) { > - synth_err(SYNTH_ERR_INVALID_TYPE, errpos(fie

[PATCH v5 2/5] tracing: Rework synthetic event command parsing

Now that command parsing has been delegated to the create functions and we're no longer constrained by argv_split(), we can modify the synthetic event command parser to better match the higher-level structure of the synthetic event commands, which is basically an event name followed by a set of sem