Re: [PATCH v5 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-19 Thread Cezary Rojewski
On 2019-07-19 09:09, Oleksandr Suvorov wrote: On Thu, 18 Jul 2019 at 21:49, Cezary Rojewski wrote: On 2019-07-18 20:42, Cezary Rojewski wrote: On 2019-07-18 11:02, Oleksandr Suvorov wrote: +enum { +HP_POWER_EVENT, +DAC_POWER_EVENT, +ADC_POWER_EVENT, +LAST_POWER_EVENT +}; + +s

Re: [PATCH v5 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-19 Thread Oleksandr Suvorov
On Thu, 18 Jul 2019 at 21:49, Cezary Rojewski wrote: > > On 2019-07-18 20:42, Cezary Rojewski wrote: > > On 2019-07-18 11:02, Oleksandr Suvorov wrote: > >> +enum { > >> +HP_POWER_EVENT, > >> +DAC_POWER_EVENT, > >> +ADC_POWER_EVENT, > >> +LAST_POWER_EVENT > >> +}; > >> + > >> +stati

Re: [PATCH v5 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-18 Thread Cezary Rojewski
On 2019-07-18 20:42, Cezary Rojewski wrote: On 2019-07-18 11:02, Oleksandr Suvorov wrote: +enum { +    HP_POWER_EVENT, +    DAC_POWER_EVENT, +    ADC_POWER_EVENT, +    LAST_POWER_EVENT +}; + +static u16 mute_mask[] = { +    SGTL5000_HP_MUTE, +    SGTL5000_OUTPUTS_MUTE, +    SGTL5000_OUTPUTS_MUTE

Re: [PATCH v5 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-18 Thread Cezary Rojewski
On 2019-07-18 11:02, Oleksandr Suvorov wrote: +enum { + HP_POWER_EVENT, + DAC_POWER_EVENT, + ADC_POWER_EVENT, + LAST_POWER_EVENT +}; + +static u16 mute_mask[] = { + SGTL5000_HP_MUTE, + SGTL5000_OUTPUTS_MUTE, + SGTL5000_OUTPUTS_MUTE +}; If mute_mask[]

Re: [PATCH v5 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-18 Thread Igor Opaniuk
On Thu, Jul 18, 2019 at 12:03 PM Oleksandr Suvorov wrote: > > VAG power control is improved to fit the manual [1]. This patch fixes as > minimum one bug: if customer muxes Headphone to Line-In right after boot, > the VAG power remains off that leads to poor sound quality from line-in. > > I.e. aft

[PATCH v5 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-18 Thread Oleksandr Suvorov
VAG power control is improved to fit the manual [1]. This patch fixes as minimum one bug: if customer muxes Headphone to Line-In right after boot, the VAG power remains off that leads to poor sound quality from line-in. I.e. after boot: - Connect sound source to Line-In jack; - Connect headpho