Re: [PATCH v5 2/6] fpga: m10bmc-sec: create max10 bmc secure update driver

2020-11-18 Thread Tom Rix
>>> + return -EINVAL; >>> + } >>> + >>> + ret = regmap_bulk_read(sec->m10bmc->regmap, reh_addr, >>> + hash, sha_num_bytes / stride); >> Assumes !(sha_num_bytes % stride) > Yes - good point. I'll add WARN_ON() here and for the CSK cancellation > vectors. >

Re: [PATCH v5 2/6] fpga: m10bmc-sec: create max10 bmc secure update driver

2020-11-17 Thread Russ Weight
On 11/15/20 5:44 AM, Tom Rix wrote: > On 11/13/20 4:55 PM, Russ Weight wrote: >> Create a platform driver that can be invoked as a sub >> driver for the Intel MAX10 BMC in order to support >> secure updates. This sub-driver will invoke an >> instance of the FPGA Security Manager class driver >>

Re: [PATCH v5 2/6] fpga: m10bmc-sec: create max10 bmc secure update driver

2020-11-15 Thread Tom Rix
On 11/13/20 4:55 PM, Russ Weight wrote: > Create a platform driver that can be invoked as a sub > driver for the Intel MAX10 BMC in order to support > secure updates. This sub-driver will invoke an > instance of the FPGA Security Manager class driver > in order to expose sysfs interfaces for

[PATCH v5 2/6] fpga: m10bmc-sec: create max10 bmc secure update driver

2020-11-13 Thread Russ Weight
Create a platform driver that can be invoked as a sub driver for the Intel MAX10 BMC in order to support secure updates. This sub-driver will invoke an instance of the FPGA Security Manager class driver in order to expose sysfs interfaces for managing and monitoring secure updates to FPGA and BMC