Re: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode

2013-09-27 Thread Toshi Kani
On Wed, 2013-09-25 at 02:27 +0800, Zhang Yanfei wrote: > From: Tang Chen > > The Linux kernel cannot migrate pages used by the kernel. As a result, kernel > pages cannot be hot-removed. So we cannot allocate hotpluggable memory for > the kernel. > > ACPI SRAT (System Resource Affinity Table) con

Re: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode

2013-09-26 Thread Zhang Yanfei
On 09/26/2013 11:37 PM, Zhang Yanfei wrote: > Hello tejun, > > Thanks for your quick comments first:) > > On 09/26/2013 10:45 PM, Tejun Heo wrote: >> Hello, >> >> On Wed, Sep 25, 2013 at 02:27:48AM +0800, Zhang Yanfei wrote: >>> +#ifdef CONFIG_MOVABLE_NODE >>> +static inline void memblock_set_bot

Re: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode

2013-09-26 Thread Zhang Yanfei
On 09/26/2013 11:50 PM, Tejun Heo wrote: > On Thu, Sep 26, 2013 at 11:37:34PM +0800, Zhang Yanfei wrote: + WARN_ONCE(1, "memblock: Failed to allocate memory in bottom up " + "direction. Now try top down direction.\n"); + } >>> >>> You and I would know what

Re: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode

2013-09-26 Thread Tejun Heo
On Thu, Sep 26, 2013 at 11:37:34PM +0800, Zhang Yanfei wrote: > >> + WARN_ONCE(1, "memblock: Failed to allocate memory in bottom up " > >> + "direction. Now try top down direction.\n"); > >> + } > > > > You and I would know what was going on and what the consequence of t

Re: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode

2013-09-26 Thread Zhang Yanfei
Hello tejun, Thanks for your quick comments first:) On 09/26/2013 10:45 PM, Tejun Heo wrote: > Hello, > > On Wed, Sep 25, 2013 at 02:27:48AM +0800, Zhang Yanfei wrote: >> +#ifdef CONFIG_MOVABLE_NODE >> +static inline void memblock_set_bottom_up(bool enable) >> +{ >> +memblock.bottom_up = ena

Re: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode

2013-09-26 Thread Tejun Heo
Hello, On Wed, Sep 25, 2013 at 02:27:48AM +0800, Zhang Yanfei wrote: > +#ifdef CONFIG_MOVABLE_NODE > +static inline void memblock_set_bottom_up(bool enable) > +{ > + memblock.bottom_up = enable; > +} > + > +static inline bool memblock_bottom_up(void) > +{ > + return memblock.bottom_up; > +

[PATCH v5 2/6] memblock: Introduce bottom-up allocation mode

2013-09-24 Thread Zhang Yanfei
From: Tang Chen The Linux kernel cannot migrate pages used by the kernel. As a result, kernel pages cannot be hot-removed. So we cannot allocate hotpluggable memory for the kernel. ACPI SRAT (System Resource Affinity Table) contains the memory hotplug info. But before SRAT is parsed, memblock ha