Re: [PATCH v5 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

Hi Mark, Thanks for your comments. On 2017/10/17 23:06, Mark Rutland wrote: > Hi, > > Apologies for the delay for this review. > > Largely this seems to look OK, but there are a couple of things which > stick out. > > On Tue, Aug 22, 2017 at 04:07:53PM +0800, Shaokun Zhang wrote: >> +int

Re: [PATCH v5 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

Hi Mark, Thanks for your comments. On 2017/10/17 23:06, Mark Rutland wrote: > Hi, > > Apologies for the delay for this review. > > Largely this seems to look OK, but there are a couple of things which > stick out. > > On Tue, Aug 22, 2017 at 04:07:53PM +0800, Shaokun Zhang wrote: >> +int

Re: [PATCH v5 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

Hi, Apologies for the delay for this review. Largely this seems to look OK, but there are a couple of things which stick out. On Tue, Aug 22, 2017 at 04:07:53PM +0800, Shaokun Zhang wrote: > +int hisi_uncore_pmu_event_init(struct perf_event *event) > +{ > + struct hw_perf_event *hwc = >hw;

Re: [PATCH v5 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

Hi, Apologies for the delay for this review. Largely this seems to look OK, but there are a couple of things which stick out. On Tue, Aug 22, 2017 at 04:07:53PM +0800, Shaokun Zhang wrote: > +int hisi_uncore_pmu_event_init(struct perf_event *event) > +{ > + struct hw_perf_event *hwc = >hw;

[PATCH v5 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

This patch adds support HiSilicon SoC uncore PMU driver framework and interfaces. Reviewed-by: Jonathan Cameron Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- drivers/perf/Kconfig | 7

[PATCH v5 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

This patch adds support HiSilicon SoC uncore PMU driver framework and interfaces. Reviewed-by: Jonathan Cameron Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- drivers/perf/Kconfig | 7 + drivers/perf/Makefile| 1 +