Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 02:55:47PM +, Arnd Bergmann wrote: > On Wednesday 03 April 2013, Felipe Balbi wrote: > > const ? Maybe provide a: > > > > #define DEFINE_PHY_OPS(name)\ > > const struct phy_ops #name_phy_ops = { > > > > macro ? This will force people to add the const keyword

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Arnd Bergmann
On Wednesday 03 April 2013, Felipe Balbi wrote: > const ? Maybe provide a: > > #define DEFINE_PHY_OPS(name)\ > const struct phy_ops #name_phy_ops = { > > macro ? This will force people to add the const keyword :-) Forcing people to use const structures is good, but I think it would be

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 06:23:50PM +0530, Kishon Vijay Abraham I wrote: > Used the generic PHY framework API to create the PHY. omap_usb2_suspend > is split into omap_usb_suspend and omap_usb_resume in order to align > with the new framework. > > However using the old USB PHY library cannot be

[PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. omap_usb2_suspend is split into omap_usb_suspend and omap_usb_resume in order to align with the new framework. However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new

[PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. omap_usb2_suspend is split into omap_usb_suspend and omap_usb_resume in order to align with the new framework. However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 06:23:50PM +0530, Kishon Vijay Abraham I wrote: Used the generic PHY framework API to create the PHY. omap_usb2_suspend is split into omap_usb_suspend and omap_usb_resume in order to align with the new framework. However using the old USB PHY library cannot be

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Arnd Bergmann
On Wednesday 03 April 2013, Felipe Balbi wrote: const ? Maybe provide a: #define DEFINE_PHY_OPS(name)\ const struct phy_ops #name_phy_ops = { macro ? This will force people to add the const keyword :-) Forcing people to use const structures is good, but I think it would be better

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 02:55:47PM +, Arnd Bergmann wrote: On Wednesday 03 April 2013, Felipe Balbi wrote: const ? Maybe provide a: #define DEFINE_PHY_OPS(name)\ const struct phy_ops #name_phy_ops = { macro ? This will force people to add the const keyword :-)