Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-11-28 Thread AKASHI Takahiro
On 11/04/2013 12:55 AM, Jiang Liu wrote: On 10/30/2013 08:12 AM, Will Deacon wrote: Hi Jinag Liu, +static __always_inline u32 aarch64_insn_read(void *addr) +{ + return le32_to_cpu(*(u32 *)addr); +} +static __always_inline void aarch64_insn_write(void *addr, u32 insn) +{ + *(u32 *)

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-11-27 Thread Jiang Liu
On 11/27/2013 08:20 PM, Will Deacon wrote: > Hi Jiang Liu, > > On Sun, Nov 03, 2013 at 03:55:21PM +, Jiang Liu wrote: >> On 10/30/2013 08:12 AM, Will Deacon wrote: >>> If I try and email you at your Huawei address, I get a bounce from the mail >>> server. Is that expected? If so, it's not very

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-11-27 Thread Will Deacon
Hi Jiang Liu, On Sun, Nov 03, 2013 at 03:55:21PM +, Jiang Liu wrote: > On 10/30/2013 08:12 AM, Will Deacon wrote: > > If I try and email you at your Huawei address, I get a bounce from the mail > > server. Is that expected? If so, it's not very helpful from a commit log > > perspective if you

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-11-06 Thread Will Deacon
On Wed, Nov 06, 2013 at 04:12:13PM +, Jiang Liu wrote: > On 11/06/2013 06:41 PM, Will Deacon wrote: > > On Mon, Nov 04, 2013 at 03:12:56PM +, Sandeepa Prabhu wrote: > >> On 3 November 2013 23:55, Jiang Liu wrote: > >>> On 10/30/2013 08:12 AM, Will Deacon wrote: > On Fri, Oct 18, 2013

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-11-06 Thread Jiang Liu
On 11/06/2013 06:41 PM, Will Deacon wrote: > On Mon, Nov 04, 2013 at 03:12:56PM +, Sandeepa Prabhu wrote: >> On 3 November 2013 23:55, Jiang Liu wrote: >>> On 10/30/2013 08:12 AM, Will Deacon wrote: On Fri, Oct 18, 2013 at 04:19:56PM +0100, Jiang Liu wrote: > +atomic_set(&text_pat

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-11-06 Thread Will Deacon
On Mon, Nov 04, 2013 at 03:12:56PM +, Sandeepa Prabhu wrote: > On 3 November 2013 23:55, Jiang Liu wrote: > > On 10/30/2013 08:12 AM, Will Deacon wrote: > >> On Fri, Oct 18, 2013 at 04:19:56PM +0100, Jiang Liu wrote: > >>> +atomic_set(&text_patch_id, smp_processor_id()); > >>> +ret = s

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-11-04 Thread Sandeepa Prabhu
On 3 November 2013 23:55, Jiang Liu wrote: > On 10/30/2013 08:12 AM, Will Deacon wrote: >> Hi Jinag Liu, >> >> Sorry for the delayed review, I've been travelling. >> >> On Fri, Oct 18, 2013 at 04:19:56PM +0100, Jiang Liu wrote: >>> From: Jiang Liu >> >> If I try and email you at your Huawei addre

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-11-03 Thread Jiang Liu
On 10/30/2013 08:12 AM, Will Deacon wrote: > Hi Jinag Liu, > > Sorry for the delayed review, I've been travelling. > > On Fri, Oct 18, 2013 at 04:19:56PM +0100, Jiang Liu wrote: >> From: Jiang Liu > > If I try and email you at your Huawei address, I get a bounce from the mail > server. Is that

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-10-29 Thread Will Deacon
Hi Jinag Liu, Sorry for the delayed review, I've been travelling. On Fri, Oct 18, 2013 at 04:19:56PM +0100, Jiang Liu wrote: > From: Jiang Liu If I try and email you at your Huawei address, I get a bounce from the mail server. Is that expected? If so, it's not very helpful from a commit log per

[PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-10-18 Thread Jiang Liu
From: Jiang Liu Introduce three interfaces to patch kernel and module code: aarch64_insn_patch_text_nosync(): patch code without synchronization, it's caller's responsibility to synchronize all CPUs if needed. aarch64_insn_patch_text_sync(): patch code and always synchroni