Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-09 Thread Andrew Morton
On Wed, 10 Apr 2019 06:06:49 +1000 "Tobin C. Harding" wrote: > On Tue, Apr 09, 2019 at 02:59:52PM +0200, Vlastimil Babka wrote: > > On 4/3/19 11:13 PM, Tobin C. Harding wrote: > > > > > According to 0day test robot this is triggering an error from > > > CHECK_DATA_CORRUPTION when the kernel is

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-09 Thread Tobin C. Harding
On Tue, Apr 09, 2019 at 02:59:52PM +0200, Vlastimil Babka wrote: > On 4/3/19 11:13 PM, Tobin C. Harding wrote: > > > According to 0day test robot this is triggering an error from > > CHECK_DATA_CORRUPTION when the kernel is built with CONFIG_DEBUG_LIST. > > FWIW, that report [1] was for commit

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-09 Thread Vlastimil Babka
On 4/3/19 11:13 PM, Tobin C. Harding wrote: > According to 0day test robot this is triggering an error from > CHECK_DATA_CORRUPTION when the kernel is built with CONFIG_DEBUG_LIST. FWIW, that report [1] was for commit 15c8410c67adef from next-20190401. I've checked and it's still the v4 version,

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-03 Thread Tobin C. Harding
On Wed, Apr 03, 2019 at 09:23:28PM +, Roman Gushchin wrote: > On Thu, Apr 04, 2019 at 08:03:27AM +1100, Tobin C. Harding wrote: > > On Wed, Apr 03, 2019 at 06:00:30PM +, Roman Gushchin wrote: > > > On Wed, Apr 03, 2019 at 10:05:40AM +1100, Tobin C. Harding wrote: > > > > Currently we reach

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-03 Thread Roman Gushchin
On Thu, Apr 04, 2019 at 08:03:27AM +1100, Tobin C. Harding wrote: > On Wed, Apr 03, 2019 at 06:00:30PM +, Roman Gushchin wrote: > > On Wed, Apr 03, 2019 at 10:05:40AM +1100, Tobin C. Harding wrote: > > > Currently we reach inside the list_head. This is a violation of the > > > layer of

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-03 Thread Tobin C. Harding
On Wed, Apr 03, 2019 at 06:00:30PM +, Roman Gushchin wrote: > On Wed, Apr 03, 2019 at 10:05:40AM +1100, Tobin C. Harding wrote: > > Currently we reach inside the list_head. This is a violation of the > > layer of abstraction provided by the list_head. It makes the code > > fragile. More

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-03 Thread Tobin C. Harding
On Wed, Apr 03, 2019 at 06:00:30PM +, Roman Gushchin wrote: > On Wed, Apr 03, 2019 at 10:05:40AM +1100, Tobin C. Harding wrote: > > Currently we reach inside the list_head. This is a violation of the > > layer of abstraction provided by the list_head. It makes the code > > fragile. More

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-03 Thread Roman Gushchin
On Wed, Apr 03, 2019 at 10:05:40AM +1100, Tobin C. Harding wrote: > Currently we reach inside the list_head. This is a violation of the > layer of abstraction provided by the list_head. It makes the code > fragile. More importantly it makes the code wicked hard to understand. > > The code

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-03 Thread Christopher Lameter
On Wed, 3 Apr 2019, Tobin C. Harding wrote: > Currently we reach inside the list_head. This is a violation of the > layer of abstraction provided by the list_head. It makes the code > fragile. More importantly it makes the code wicked hard to understand. Great It definitely makes it

[PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-02 Thread Tobin C. Harding
Currently we reach inside the list_head. This is a violation of the layer of abstraction provided by the list_head. It makes the code fragile. More importantly it makes the code wicked hard to understand. The code reaches into the list_head structure to counteract the fact that the list _may_