On Mon, Dec 03, 2018 at 10:59:10AM +0100, Roberto Sassu wrote:
> On 11/30/2018 8:45 PM, Jarkko Sakkinen wrote:
> > On Fri, Nov 30, 2018 at 11:41:49AM -0800, Jarkko Sakkinen wrote:
> > > Even after looking at the spec the last field does not make sense as the
> > > event after digests and digests ar
On 11/30/2018 8:45 PM, Jarkko Sakkinen wrote:
On Fri, Nov 30, 2018 at 11:41:49AM -0800, Jarkko Sakkinen wrote:
Even after looking at the spec the last field does not make sense as the
event after digests and digests are not in union. It is just not right.
The comment does not fix that.
You sh
On Fri, Nov 30, 2018 at 11:45:27AM -0800, Jarkko Sakkinen wrote:
> On Fri, Nov 30, 2018 at 11:41:49AM -0800, Jarkko Sakkinen wrote:
> > Even after looking at the spec the last field does not make sense as the
> > event after digests and digests are not in union. It is just not right.
> >
> > The c
On Fri, Nov 30, 2018 at 11:41:49AM -0800, Jarkko Sakkinen wrote:
> Even after looking at the spec the last field does not make sense as the
> event after digests and digests are not in union. It is just not right.
>
> The comment does not fix that.
You should remove the last field and rename the
On Thu, Nov 29, 2018 at 01:04:40PM +0100, Roberto Sassu wrote:
> > > > + struct tpm2_digest digests[0];
> > > > struct tcg_event_field event;
> > > > } __packed;
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > NAK for the same reason as last time.
> >
> > I added this comment to includ
On 11/28/2018 1:17 PM, Roberto Sassu wrote:
On 11/16/2018 2:38 PM, Jarkko Sakkinen wrote:
On Wed, Nov 14, 2018 at 04:31:03PM +0100, Roberto Sassu wrote:
tcg_efi_specid_event and tcg_pcr_event2 declaration contains static
arrays
for a list of hash algorithms used for event logs and event log di
On 11/16/2018 2:38 PM, Jarkko Sakkinen wrote:
On Wed, Nov 14, 2018 at 04:31:03PM +0100, Roberto Sassu wrote:
tcg_efi_specid_event and tcg_pcr_event2 declaration contains static arrays
for a list of hash algorithms used for event logs and event log digests.
However, according to TCG EFI Protocol
On 11/16/2018 2:38 PM, Jarkko Sakkinen wrote:
On Wed, Nov 14, 2018 at 04:31:03PM +0100, Roberto Sassu wrote:
tcg_efi_specid_event and tcg_pcr_event2 declaration contains static arrays
for a list of hash algorithms used for event logs and event log digests.
However, according to TCG EFI Protocol
On Wed, Nov 14, 2018 at 04:31:03PM +0100, Roberto Sassu wrote:
> tcg_efi_specid_event and tcg_pcr_event2 declaration contains static arrays
> for a list of hash algorithms used for event logs and event log digests.
>
> However, according to TCG EFI Protocol Specification, these arrays have
> varia
tcg_efi_specid_event and tcg_pcr_event2 declaration contains static arrays
for a list of hash algorithms used for event logs and event log digests.
However, according to TCG EFI Protocol Specification, these arrays have
variable sizes. Setting the array size to zero or 3 does not make any
differen
10 matches
Mail list logo
