Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-08-05 Thread Sudeep Holla
On 31/07/15 14:45, Jassi Brar wrote: On Fri, Jul 31, 2015 at 6:38 PM, Sudeep Holla wrote: On 31/07/15 11:43, Sudeep Holla wrote: On 31/07/15 11:38, Jassi Brar wrote: On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla wrote: I forgot to mention, we have a the following description in

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-08-05 Thread Sudeep Holla
On 31/07/15 14:45, Jassi Brar wrote: On Fri, Jul 31, 2015 at 6:38 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 31/07/15 11:43, Sudeep Holla wrote: On 31/07/15 11:38, Jassi Brar wrote: On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla sudeep.ho...@arm.com wrote: I forgot to mention,

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Jassi Brar
On Fri, Jul 31, 2015 at 6:38 PM, Sudeep Holla wrote: > > > On 31/07/15 11:43, Sudeep Holla wrote: >> >> >> >> On 31/07/15 11:38, Jassi Brar wrote: >>> >>> On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla >>> wrote: I forgot to mention, we have a the following description in

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Sudeep Holla
On 31/07/15 11:43, Sudeep Holla wrote: On 31/07/15 11:38, Jassi Brar wrote: On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla wrote: I forgot to mention, we have a the following description in mbox_client_txdone which is misleading: "The client/protocol had received some 'ACK' packet and it

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Sudeep Holla
On 31/07/15 11:38, Jassi Brar wrote: On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla wrote: I forgot to mention, we have a the following description in mbox_client_txdone which is misleading: "The client/protocol had received some 'ACK' packet and it notifies the API that the last packet was

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Jassi Brar
On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla wrote: > > I forgot to mention, we have a the following description in > mbox_client_txdone which is misleading: > > "The client/protocol had received some 'ACK' packet and it notifies the > API that the last packet was sent successfully. This only

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Sudeep Holla
On 30/07/15 18:56, Jassi Brar wrote: On Wed, Jul 29, 2015 at 6:20 PM, Sudeep Holla wrote: On 29/07/15 12:19, Jassi Brar wrote: Assuming the former, let me explain. When a client receives a response, it can be sure that the request has already been read by the remote. Waiting for the

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Sudeep Holla
On 30/07/15 18:56, Jassi Brar wrote: On Wed, Jul 29, 2015 at 6:20 PM, Sudeep Holla wrote: On 29/07/15 12:19, Jassi Brar wrote: Assuming the former, let me explain. When a client receives a response, it can be sure that the request has already been read by the remote. Waiting for the

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Sudeep Holla
On 31/07/15 11:43, Sudeep Holla wrote: On 31/07/15 11:38, Jassi Brar wrote: On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla sudeep.ho...@arm.com wrote: I forgot to mention, we have a the following description in mbox_client_txdone which is misleading: The client/protocol had received some

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Jassi Brar
On Fri, Jul 31, 2015 at 6:38 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 31/07/15 11:43, Sudeep Holla wrote: On 31/07/15 11:38, Jassi Brar wrote: On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla sudeep.ho...@arm.com wrote: I forgot to mention, we have a the following description in

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Sudeep Holla
On 30/07/15 18:56, Jassi Brar wrote: On Wed, Jul 29, 2015 at 6:20 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 29/07/15 12:19, Jassi Brar wrote: Assuming the former, let me explain. When a client receives a response, it can be sure that the request has already been read by the remote.

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Sudeep Holla
On 30/07/15 18:56, Jassi Brar wrote: On Wed, Jul 29, 2015 at 6:20 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 29/07/15 12:19, Jassi Brar wrote: Assuming the former, let me explain. When a client receives a response, it can be sure that the request has already been read by the remote.

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Jassi Brar
On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla sudeep.ho...@arm.com wrote: I forgot to mention, we have a the following description in mbox_client_txdone which is misleading: The client/protocol had received some 'ACK' packet and it notifies the API that the last packet was sent successfully.

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Sudeep Holla
On 31/07/15 11:38, Jassi Brar wrote: On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla sudeep.ho...@arm.com wrote: I forgot to mention, we have a the following description in mbox_client_txdone which is misleading: The client/protocol had received some 'ACK' packet and it notifies the API that

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-30 Thread Jassi Brar
On Wed, Jul 29, 2015 at 6:20 PM, Sudeep Holla wrote: > On 29/07/15 12:19, Jassi Brar wrote: > >> Assuming the former, let me explain. When a client receives a >> response, it can be sure that the request has already been read by the >> remote. > > Waiting for the response would be too late for

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-30 Thread Jassi Brar
On Wed, Jul 29, 2015 at 6:20 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 29/07/15 12:19, Jassi Brar wrote: Assuming the former, let me explain. When a client receives a response, it can be sure that the request has already been read by the remote. Waiting for the response would be too

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Sudeep Holla
On 29/07/15 12:19, Jassi Brar wrote: On Wed, Jul 29, 2015 at 2:08 PM, Sudeep Holla wrote: On 29/07/15 09:05, Jassi Brar wrote: +static int scpi_probe(struct platform_device *pdev) +{ + int count, idx, ret; + struct resource res; + struct scpi_chan *scpi_chan; +

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Jassi Brar
On Wed, Jul 29, 2015 at 2:08 PM, Sudeep Holla wrote: > On 29/07/15 09:05, Jassi Brar wrote: > >> >>> +static int scpi_probe(struct platform_device *pdev) >>> +{ >>> + int count, idx, ret; >>> + struct resource res; >>> + struct scpi_chan *scpi_chan; >>> + struct device

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Sudeep Holla
On 29/07/15 09:05, Jassi Brar wrote: On Thu, Jul 23, 2015 at 4:40 PM, Sudeep Holla wrote: ... +static int scpi_probe(struct platform_device *pdev) +{ + int count, idx, ret; + struct resource res; + struct scpi_chan *scpi_chan; + struct device *dev = >dev; +

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Jassi Brar
On Thu, Jul 23, 2015 at 4:40 PM, Sudeep Holla wrote: ... > +static int scpi_probe(struct platform_device *pdev) > +{ > + int count, idx, ret; > + struct resource res; > + struct scpi_chan *scpi_chan; > + struct device *dev = >dev; > + struct device_node *np =

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Jassi Brar
On Thu, Jul 23, 2015 at 4:40 PM, Sudeep Holla sudeep.ho...@arm.com wrote: ... +static int scpi_probe(struct platform_device *pdev) +{ + int count, idx, ret; + struct resource res; + struct scpi_chan *scpi_chan; + struct device *dev = pdev-dev; + struct

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Sudeep Holla
On 29/07/15 09:05, Jassi Brar wrote: On Thu, Jul 23, 2015 at 4:40 PM, Sudeep Holla sudeep.ho...@arm.com wrote: ... +static int scpi_probe(struct platform_device *pdev) +{ + int count, idx, ret; + struct resource res; + struct scpi_chan *scpi_chan; + struct device

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Jassi Brar
On Wed, Jul 29, 2015 at 2:08 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 29/07/15 09:05, Jassi Brar wrote: +static int scpi_probe(struct platform_device *pdev) +{ + int count, idx, ret; + struct resource res; + struct scpi_chan *scpi_chan; + struct device *dev

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Sudeep Holla
On 29/07/15 12:19, Jassi Brar wrote: On Wed, Jul 29, 2015 at 2:08 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 29/07/15 09:05, Jassi Brar wrote: +static int scpi_probe(struct platform_device *pdev) +{ + int count, idx, ret; + struct resource res; + struct scpi_chan

[PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-23 Thread Sudeep Holla
This patch adds support for System Control and Power Interface (SCPI) Message Protocol used between the Application Cores(AP) and the System Control Processor(SCP). The MHU peripheral provides a mechanism for inter-processor communication between SCP's M3 processor and AP. SCP offers control and

[PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-23 Thread Sudeep Holla
This patch adds support for System Control and Power Interface (SCPI) Message Protocol used between the Application Cores(AP) and the System Control Processor(SCP). The MHU peripheral provides a mechanism for inter-processor communication between SCP's M3 processor and AP. SCP offers control and