Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-23 Thread Michael Wang
On 04/22/2015 06:45 PM, ira.weiny wrote: > On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote: >> >> On 04/22/2015 07:40 AM, Jason Gunthorpe wrote: >>> On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: >>> Introduce helper cap_ipoib() to help us check if the port of a

Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-23 Thread Michael Wang
On 04/22/2015 07:24 PM, Jason Gunthorpe wrote: > On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote: >> >> On 04/22/2015 07:40 AM, Jason Gunthorpe wrote: >>> On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: >>> Introduce helper cap_ipoib() to help us check if the por

Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-22 Thread Jason Gunthorpe
On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote: > > On 04/22/2015 07:40 AM, Jason Gunthorpe wrote: > > On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: > > > >> Introduce helper cap_ipoib() to help us check if the port of an > >> IB device support IP over Infiniband. >

RE: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-22 Thread Hefty, Sean
> > > I thought we were dropping this in favor of listing the actual > > > features the ULP required unconditionally? One of my messages had the > > > start of a list.. > > ??? I forget. I was arguing that we should not have it. But I thought > others > disagreed with me so it was left in. I d

Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-22 Thread ira.weiny
On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote: > > On 04/22/2015 07:40 AM, Jason Gunthorpe wrote: > > On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: > > > >> Introduce helper cap_ipoib() to help us check if the port of an > >> IB device support IP over Infiniband. >

Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-22 Thread Michael Wang
On 04/22/2015 07:40 AM, Jason Gunthorpe wrote: > On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: > >> Introduce helper cap_ipoib() to help us check if the port of an >> IB device support IP over Infiniband. > > I thought we were dropping this in favor of listing the actual > featu

Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-21 Thread Jason Gunthorpe
On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: > Introduce helper cap_ipoib() to help us check if the port of an > IB device support IP over Infiniband. I thought we were dropping this in favor of listing the actual features the ULP required unconditionally? One of my messages had

Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: > > Introduce helper cap_ipoib() to help us check if the port of an > IB device support IP over Infiniband. > > Cc: Hal Rosenstock > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: S

[PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-20 Thread Michael Wang
Introduce helper cap_ipoib() to help us check if the port of an IB device support IP over Infiniband. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/ulp/ipoib/ipoib_main