Re: [PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration

2015-11-05 Thread Krzysztof Kozlowski
W dniu 05.11.2015 o 19:40, Pavel Fedin pisze: > Hello! > >>> +static int decode_sromc(struct exynos_srom *srom, struct device_node *np) >> >> I missed that one previously: add prefix and more descriptive name, like: >> exynos_srom_parse_child() > > exynos_srom_configure_bank(), is this name OK?

RE: [PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration

2015-11-05 Thread Pavel Fedin
Hello! > > +static int decode_sromc(struct exynos_srom *srom, struct device_node *np) > > I missed that one previously: add prefix and more descriptive name, like: > exynos_srom_parse_child() exynos_srom_configure_bank(), is this name OK? > > static int exynos_srom_probe(struct platform_devi

Re: [PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration

2015-11-04 Thread Krzysztof Kozlowski
On 03.11.2015 18:16, Pavel Fedin wrote: > Implement handling properties in subnodes and adding child devices to the > system. Child devices will not be added if configuration fails. > > Since the driver now does more than suspend-resume support, dependency on > CONFIG_PM is removed. > > Signed-of

[PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration

2015-11-03 Thread Pavel Fedin
Implement handling properties in subnodes and adding child devices to the system. Child devices will not be added if configuration fails. Since the driver now does more than suspend-resume support, dependency on CONFIG_PM is removed. Signed-off-by: Pavel Fedin --- arch/arm/mach-exynos/Kconfig