Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Rob Herring
On Thu, Feb 11, 2021 at 2:45 PM Stephen Boyd wrote: > > Quoting Matthias Kaehlcke (2021-02-11 12:36:35) > > Hi Stephen, > > > > On Thu, Feb 11, 2021 at 11:14:39AM -0800, Stephen Boyd wrote: > > > > > > Is it possible to use the graph binding to connect the USB controller on > > > the SoC to the po

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Rob Herring
On Thu, Feb 11, 2021 at 1:14 PM Stephen Boyd wrote: > > Quoting Matthias Kaehlcke (2021-02-10 14:20:18) > > > > On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote: > > > > > > This looks hackish... what if later we have something else than hub? > > > Another if()? > > > > > > What

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Stephen Boyd
Quoting Matthias Kaehlcke (2021-02-11 12:36:35) > Hi Stephen, > > On Thu, Feb 11, 2021 at 11:14:39AM -0800, Stephen Boyd wrote: > > > > Is it possible to use the graph binding to connect the USB controller on > > the SoC to the port on the hub? Then the hub would be a standalone node > > at the r

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Matthias Kaehlcke
Hi Stephen, On Thu, Feb 11, 2021 at 11:14:39AM -0800, Stephen Boyd wrote: > Quoting Matthias Kaehlcke (2021-02-10 14:20:18) > > > > On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote: > > > > > > This looks hackish... what if later we have something else than hub? > > > Another

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Stephen Boyd
Quoting Matthias Kaehlcke (2021-02-10 14:20:18) > > On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote: > > > > This looks hackish... what if later we have something else than hub? > > Another if()? > > > > What if hub could be connected to something else than XHCI controller? >

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Matthias Kaehlcke
On Thu, Feb 11, 2021 at 10:45:48AM -0800, Matthias Kaehlcke wrote: > Hi Greg, > > On Thu, Feb 11, 2021 at 07:58:23AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote: > > > Check during probe() if a hub supported by the onboard_usb_hub > > > dr

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Matthias Kaehlcke
Hi Greg, On Thu, Feb 11, 2021 at 07:58:23AM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote: > > Check during probe() if a hub supported by the onboard_usb_hub > > driver is connected to the controller. If such a hub is found > > create the corr

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-10 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote: > Check during probe() if a hub supported by the onboard_usb_hub > driver is connected to the controller. If such a hub is found > create the corresponding platform device. This requires the > device tree to have a node for the hub

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-10 Thread kernel test robot
Hi Matthias, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on robh/for-next char-misc/char-misc-testing v5.11-rc7 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-10 Thread kernel test robot
Hi Matthias, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on robh/for-next char-misc/char-misc-testing v5.11-rc7 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-10 Thread Matthias Kaehlcke
Hi Krzysztof, On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote: > On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote: > > Check during probe() if a hub supported by the onboard_usb_hub > > driver is connected to the controller. If such a hub is found > > create th

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote: > Check during probe() if a hub supported by the onboard_usb_hub > driver is connected to the controller. If such a hub is found > create the corresponding platform device. This requires the > device tree to have a node for the hub

[PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-10 Thread Matthias Kaehlcke
Check during probe() if a hub supported by the onboard_usb_hub driver is connected to the controller. If such a hub is found create the corresponding platform device. This requires the device tree to have a node for the hub with its vendor and product id (which is not common for USB devices). Furth