Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-03-26 Thread Pavel Machek
Hi! > > No, we need some kind of at least rudimentary gps framework even if we > > allow for a raw (NMEA) interface for the time being (possibly > > indefinitely). > > Ok, that would be fine if we can get that! > > For a minimal set of API I think something like this (following hci_dev) > would

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-03-20 Thread H. Nikolaus Schaller
Hi Johan, > Am 19.03.2018 um 14:54 schrieb Johan Hovold : > > On Tue, Feb 27, 2018 at 08:32:50AM +0100, H. Nikolaus Schaller wrote: >> Hi Johan, >> >>> Am 27.02.2018 um 08:04 schrieb Johan Hovold : >>> >>> On Mon, Feb 12, 2018 at 04:26:18PM +0100, Pavel Machek wrote: Hi! >> Let's

Re: [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-03-19 Thread Johan Hovold
On Wed, Mar 07, 2018 at 04:53:12PM +0100, H. Nikolaus Schaller wrote: > If I look for example at the camera module drivers provided by > drivers/media/i2c, most of them could be easily power-controlled from > user-space by i2c-tools and 1-2 gpios through /sys/class/gpio and > a big set of scripts.

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-03-19 Thread Johan Hovold
On Thu, Mar 08, 2018 at 07:16:44AM +0100, Andreas Kemnade wrote: > Hi, > > On Thu, 18 Jan 2018 17:47:36 +1100 > Johan Hovold wrote: > > [...] > > > > > > So to avoid having hardware information spread all over the table at least > > > these information would need to be in devicetree. But that a

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-03-19 Thread Johan Hovold
On Tue, Feb 27, 2018 at 08:32:50AM +0100, H. Nikolaus Schaller wrote: > Hi Johan, > > > Am 27.02.2018 um 08:04 schrieb Johan Hovold : > > > > On Mon, Feb 12, 2018 at 04:26:18PM +0100, Pavel Machek wrote: > >> Hi! > >> > Let's restart this discussion and focus on the main roadblock (others >

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-03-07 Thread Andreas Kemnade
Hi, On Thu, 18 Jan 2018 17:47:36 +1100 Johan Hovold wrote: [...] > > > > So to avoid having hardware information spread all over the table at least > > these information would need to be in devicetree. But that also all feels > > like a hack and hard to maintain. > > Having the device descri

Re: [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-03-07 Thread H. Nikolaus Schaller
Hi Johan, I know you have a lot of other things to do, but we are still waiting for a statement that this driver will be accepted after fixing the final coding issues. Please advise on how you want to proceed with this. One more technical comment/question/aspect below: > Am 18.01.2018 um 14:43

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-02-27 Thread Pavel Machek
Hi! > > > > Let's restart this discussion and focus on the main roadblock (others > > > > are minor details which can be sorted out later). > > > > > > > > If it feels like a hack, the key issue seems to me to be the choice of > > > > the API to present the GPS data to user space. Right? > > > >

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-02-26 Thread H. Nikolaus Schaller
Hi Johan, > Am 27.02.2018 um 08:04 schrieb Johan Hovold : > > On Mon, Feb 12, 2018 at 04:26:18PM +0100, Pavel Machek wrote: >> Hi! >> Let's restart this discussion and focus on the main roadblock (others are minor details which can be sorted out later). If it feels like a ha

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-02-26 Thread Johan Hovold
On Mon, Feb 12, 2018 at 04:26:18PM +0100, Pavel Machek wrote: > Hi! > > > > Let's restart this discussion and focus on the main roadblock (others > > > are minor details which can be sorted out later). > > > > > > If it feels like a hack, the key issue seems to me to be the choice of > > > the AP

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-02-12 Thread Pavel Machek
Hi! > > Let's restart this discussion and focus on the main roadblock (others > > are minor details which can be sorted out later). > > > > If it feels like a hack, the key issue seems to me to be the choice of > > the API to present the GPS data to user space. Right? > > Or even more fundamenta

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-02-12 Thread Pavel Machek
Hi! > >> I'm sorry (and I know this discussion has been going on for a long > >> time),but this still feels like too much of a hack. > > Happy new year ... Happy new attempt... > > Let's restart this discussion and focus on the main roadblock (others are > minor > details which can be sorted ou

Re: [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-18 Thread H. Nikolaus Schaller
Hi Johan, > Am 18.01.2018 um 07:13 schrieb Johan Hovold : > > Hacks are never good, but sometimes needed. But we should try to keep > them contained in drivers rather than allow them to spread to core code, > was what I was trying to say above. Well, aren't we talking here about a well isolated

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-17 Thread Johan Hovold
On Fri, Jan 12, 2018 at 07:40:35PM +0100, Andreas Kemnade wrote: > On Fri, 12 Jan 2018 15:46:47 +0100 > Johan Hovold wrote: > > > On Tue, Jan 09, 2018 at 06:43:47PM +0100, Andreas Kemnade wrote: > > > On Fri, 22 Dec 2017 13:44:27 +0100 > > > Johan Hovold wrote: > > > > > > [...] > > > > I'd s

Re: [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-17 Thread Johan Hovold
On Fri, Jan 12, 2018 at 06:59:59PM +0100, H. Nikolaus Schaller wrote: > Hi Johan, > > > Am 12.01.2018 um 16:39 schrieb Johan Hovold : > > > >> Let's restart this discussion and focus on the main roadblock (others > >> are minor details which can be sorted out later). > >> > >> If it feels like a

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-12 Thread Andreas Kemnade
On Fri, 12 Jan 2018 15:46:47 +0100 Johan Hovold wrote: > On Tue, Jan 09, 2018 at 06:43:47PM +0100, Andreas Kemnade wrote: > > On Fri, 22 Dec 2017 13:44:27 +0100 > > Johan Hovold wrote: > > > > [...] > > > I'd suggest reiterating the problem you're trying to solve and > > > enumerating the pre

Re: [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-12 Thread H. Nikolaus Schaller
Hi Johan, > Am 12.01.2018 um 16:39 schrieb Johan Hovold : > >> Let's restart this discussion and focus on the main roadblock (others >> are minor details which can be sorted out later). >> >> If it feels like a hack, the key issue seems to me to be the choice of >> the API to present the GPS dat

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-12 Thread Johan Hovold
On Tue, Jan 09, 2018 at 12:55:11PM +0100, H. Nikolaus Schaller wrote: > Hi Johan, > > > Am 22.12.2017 um 15:40 schrieb H. Nikolaus Schaller : > > > > Hi Johan, > > > >> Am 22.12.2017 um 13:44 schrieb Johan Hovold : > >> > >> On Fri, Dec 01, 2017 at 08:49:36AM +0100, H. Nikolaus Schaller wrote:

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-12 Thread Johan Hovold
On Tue, Jan 09, 2018 at 06:43:47PM +0100, Andreas Kemnade wrote: > On Fri, 22 Dec 2017 13:44:27 +0100 > Johan Hovold wrote: > > [...] > > I'd suggest reiterating the problem you're trying to solve and > > enumerating the previously discussed potential solutions in order to > > find a proper abstr

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-09 Thread Andreas Kemnade
On Fri, 22 Dec 2017 13:44:27 +0100 Johan Hovold wrote: [...] > I'd suggest reiterating the problem you're trying to solve and > enumerating the previously discussed potential solutions in order to > find a proper abstraction level for this (before getting lost in > implementation details). > The

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-09 Thread H. Nikolaus Schaller
Hi Johan, > Am 22.12.2017 um 15:40 schrieb H. Nikolaus Schaller : > > Hi Johan, > >> Am 22.12.2017 um 13:44 schrieb Johan Hovold : >> >> On Fri, Dec 01, 2017 at 08:49:36AM +0100, H. Nikolaus Schaller wrote: >>> Add driver for Wi2Wi W2SG0004/84 GPS module connected to some SoC UART. >>> >>> It

Re: [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2017-12-22 Thread H. Nikolaus Schaller
Hi Johan, > Am 22.12.2017 um 13:44 schrieb Johan Hovold : > > On Fri, Dec 01, 2017 at 08:49:36AM +0100, H. Nikolaus Schaller wrote: >> Add driver for Wi2Wi W2SG0004/84 GPS module connected to some SoC UART. >> >> It uses serdev API hooks to monitor and forward the UART traffic to >> /dev/ttyGPS

Re: [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2017-12-22 Thread Johan Hovold
On Fri, Dec 01, 2017 at 08:49:36AM +0100, H. Nikolaus Schaller wrote: > Add driver for Wi2Wi W2SG0004/84 GPS module connected to some SoC UART. > > It uses serdev API hooks to monitor and forward the UART traffic to > /dev/ttyGPSn > and turn on/off the module. It also detects if the module is tur

[PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2017-11-30 Thread H. Nikolaus Schaller
Add driver for Wi2Wi W2SG0004/84 GPS module connected to some SoC UART. It uses serdev API hooks to monitor and forward the UART traffic to /dev/ttyGPSn and turn on/off the module. It also detects if the module is turned on (sends data) but should be off, e.g. if it was already turned on during b