On 03/21/2017 04:27 AM, Russell King - ARM Linux wrote:
On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote:
@@ -1173,15 +1196,8 @@ static void csi_try_fmt(struct csi_priv *priv,
incc = imx_media_find_mbus_format(infmt->code,
Hi Philipp, Russell,
On 03/20/2017 10:23 AM, Philipp Zabel wrote:
Hi Steve, Russell,
What do you think of this:
--8<--
From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001
From: Philipp Zabel
Date: Mon, 20 Mar 2017 17:10:21 +0100
Subject: [PATCH] media: im
On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote:
> @@ -1173,15 +1196,8 @@ static void csi_try_fmt(struct csi_priv *priv,
> incc = imx_media_find_mbus_format(infmt->code,
> CS_SEL_ANY, true);
>
> - if (sdformat
On 03/20/2017 10:23 AM, Philipp Zabel wrote:
Hi Steve, Russell,
On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote:
On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
The same document says:
Sca
On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote:
> --8<--
> >From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001
> From: Philipp Zabel
> Date: Mon, 20 Mar 2017 17:10:21 +0100
> Subject: [PATCH] media: imx: csi: add sink selection rectangles
>
> Mov
On 03/20/2017 07:00 AM, Philipp Zabel wrote:
On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote:
The above paragraph suggests we skip any rectangles that are not
supported. In our case that would be 3. and 4., since
On Mon, Mar 20, 2017 at 06:40:21PM +0100, Philipp Zabel wrote:
> On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote:
> > I have tripped over a bug in media-ctl when specifying both a crop and
> > compose rectangle - the --help output suggests that "," should be used
> > to separate t
On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
> > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> > > The same document says:
> > >
> > > Scaling support is optional. When supported by a su
Hi Steve, Russell,
On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
> > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> > > The same document says:
> > >
> > > Scaling support is optional. Wh
On Mon, Mar 20, 2017 at 02:17:05PM +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
> > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> > > The same document says:
> > >
> > > Scaling support is optional. When supported
On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote:
> > The above paragraph suggests we skip any rectangles that are not
> > supported. In our case that would be 3. and 4., since the CSI can't
> > compose into a larger
On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
> On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> > The same document says:
> >
> > Scaling support is optional. When supported by a subdev, the crop
> > rectangle on the subdev's sink pad is scaled to the size
On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote:
> The above paragraph suggests we skip any rectangles that are not
> supported. In our case that would be 3. and 4., since the CSI can't
> compose into a larger frame. I hadn't realised that the crop selection
> currently happens on the
On Sun, 2017-03-19 at 12:08 -0700, Steve Longerbeam wrote:
>
> On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote:
> > On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote:
> >> From: Philipp Zabel
> >>
> >> The csi_try_crop call in set_fmt should compare the cropping rectangle
>
On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote:
On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote:
From: Philipp Zabel
The csi_try_crop call in set_fmt should compare the cropping rectangle
to the currently set input format, not to the previous input format.
Are we re
On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote:
> From: Philipp Zabel
>
> The csi_try_crop call in set_fmt should compare the cropping rectangle
> to the currently set input format, not to the previous input format.
Are we really sure that the cropping support is implemented co
From: Philipp Zabel
The csi_try_crop call in set_fmt should compare the cropping rectangle
to the currently set input format, not to the previous input format.
Signed-off-by: Philipp Zabel
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-csi.c | 11 +--
1 file c
17 matches
Mail list logo
